Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 350021

Summary:

[client][git] Ambiguous tab titles for Git Status and Git Log pages

Product:

[ECD] Orion

Reporter:

Tomasz Zarna <tomasz.zarna>

Component:

Git

Assignee:

Szymon Brandys <Szymon.Brandys>

Status:

RESOLVED FIXED

QA Contact:

Severity:

minor

Priority:

CC:

edyta.przymus, malgorzata.tomczyk, simon_kaegi, Szymon.Brandys

Version:

0.2

Target Milestone:

0.5 M2

Hardware:

OS:

Windows XP

Whiteboard:

Bug Depends on:

Bug Blocks:

376978

Attachments:

Description	Flags
Git Status and Git Log titles	none

Description Tomasz Zarna

2011-06-22 05:20:26 EDT

Steps:
1. Clone a repository into a folder "test"
2. Open Git Status for the repo in a new tab
=> The tab opens as "Git Status" but after a while changes into "test on master"
3. Open "Complete log" for master in a new tab
=> The tab opens as "Git Log" but after a while changes into "master on test"
4. Go to "Navigator" tab

Now I want to switch back to the page with status but don't know which one is it: "test on master" or "master on test". The titles could be more descriptive. How about "Git Status: test on master" and "Git Log: master on test"?

Comment 1 Szymon Brandys

2011-06-22 05:30:28 EDT

(In reply to comment #0)
> Now I want to switch back to the page with status but don't know which one is
> it: "test on master" or "master on test". The titles could be more descriptive.
> How about "Git Status: test on master" and "Git Log: master on test"?

I would use "test on master" in both titles and the question is where to put the task name. It depends on what is more important to display in the tab title.

So it would be either something like:
Git Status - test on master or Git Status for 'test on master' etc.

or:
test on master - Git Status or test on master (Git Status) etc.

I would tent to the second, where the resource id is first to show. But I wonder what others think.

Comment 2 Susan McCourt

2012-02-07 13:19:01 EST

is this bug "fixed enough" now that we have different favicons for git status and git log in RC1?

Comment 3 libing wang

2012-02-07 16:32:38 EST

(In reply to comment #2)
> is this bug "fixed enough" now that we have different favicons for git status
> and git log in RC1?

I think it is good enough unless Tomasz and Szymon have objections.

Comment 4 Tomasz Zarna

2012-02-08 10:45:08 EST

Created attachment 210739 [details]
Git Status and Git Log titles

Git Status and Git Log titles haven't changed. They still say "{repo} on {branch}" and "{branch} on {repo}" respectively.

Comment 5 Szymon Brandys

2012-03-19 10:56:00 EDT

To make it consistent with other Git pages I would suggest the following changes:
- window title should be "Status for <repoName> - Git" e.g. "Status for orion.client.core - Git"
- breadcrumb in the page header should be - "Repositories >> <repoName> >> Status" e.g. "Repositories >> orion.client.core >> Status"

Comment 6 Szymon Brandys

2012-03-19 10:57:20 EDT

Similar changes should be done for Git Log page. I'll handle the Log part, Could you Libing take a look at the Status page?

Comment 7 Edyta Przymus

2012-04-09 15:24:17 EDT

https://github.com/edytaprzymus/orion.client/commit/bd71c6a14808dee86ed6bbd2c0153ef7a15a5aa9

Here is my commit where I have implemented changes described here.

Comment 8 Szymon Brandys

2012-04-17 10:15:10 EDT

Fixed with 8860b55a83fd66b90f2529515ffe445a7554d64d. I made some minor changes before merging in to master.

Comment 9 Szymon Brandys

2012-04-17 10:17:47 EDT

The next step would be bug 376978.

Comment 10 Edyta Przymus

2012-07-10 08:34:38 EDT

I wrote all this code and have the rights to contribute it to Eclipse under the
eclipse.org web site terms of use.