Bugzilla – Full Text Bug Listing
| Summary: | [client] Refresh button | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | [ECD] Orion | Reporter: | Szymon Brandys <Szymon.Brandys> | ||||||
| Component: | Client | Assignee: | Project Inbox <orion.client-inbox> | ||||||
| Status: | RESOLVED WONTFIX | QA Contact: | |||||||
| Severity: | normal | ||||||||
| Priority: | P3 | CC: | grant_gayed, jarthana, mamacdon, simon_kaegi, susan, tomasz.zarna | ||||||
| Version: | 0.2 | ||||||||
| Target Milestone: | --- | ||||||||
| Hardware: | PC | ||||||||
| OS: | Windows XP | ||||||||
| Whiteboard: | |||||||||
| Attachments: |
|
||||||||
|
Description
Szymon Brandys
On the Navigator page, being able to refresh a selected subtree would also be handy in some cases. Created attachment 206722 [details]
Proposed fix
The proposed fix adds a new command Refresh to the editor alongside save. The command just fetches the file content and update the editor content.
What it doesn't do, yet, is warn if editor content has changed. But before working on this further would like to hear if this is what we need indeed.
(In reply to comment #2) > The proposed fix adds a new command Refresh to the editor alongside save. The > command just fetches the file content and update the editor content. > > What it doesn't do, yet, is warn if editor content has changed. But before > working on this further would like to hear if this is what we need indeed. It would be interesting to compare the speed of this refresh with a reload of the page. If I saw "deeper" I would first think, wait, how is this different from reloading? And i might think it's "deeper" somehow than a reload, such as a server-side synch, etc. So I think it's important to establish that this saves a ton of time. (In reply to comment #3) > If I saw "deeper" I would first think, wait, how is this different > from reloading? And i might think it's "deeper" somehow than a reload, such as > a server-side synch, etc. I meant.. if I see "refresh" I might think it's somehow "deeper" than a reload. Also, I wonder about an icon here. gmail uses a "reload" looking icon and I think that helps you know what's going on, it just seems like a "faster reload." (I realize they use "refresh" in the tooltip). Created attachment 206756 [details]
Updated patch
Same patch but with the confirmation dialog for the refresh.
(In reply to comment #5) > Created attachment 206756 [details] > Updated patch > > Same patch but with the confirmation dialog for the refresh. Can anyone look at this patch and see if this is okay? I second Susan's question.. does this offer much value over a browser reload? I'd rather we didn't reinvent concepts that the browser takes care of for us. We aggressively cache all page content so doing a browser refresh should only be doing server hits for the xhr content (like the file being edited). I guess in the context of the editor this could be called "Revert" which is a reasonable thing to provide. I see a benefit of having a refresh button on pages. When I use browser refresh on FF the page becomes blank and then populated with content, even if something is cached. This is different if you have refresh on a page, only parts that are changed are re-displayed, so usually the header, footer are not touched. The overall experience is better. I've been considering a refresh button on new git repo and status pages. Closing as part of a mass clean up of inactive bugs. Please reopen if this problem still occurs or is relevant to you. For more details see: https://dev.eclipse.org/mhonarc/lists/orion-dev/msg03444.html |