Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 349969

Summary: Code contribution for Zest (Tag Cloud Viewer)
Product: [Tools] GEF Reporter: Stephan Schwiebert <stephan.schwiebert>
Component: GEF-Legacy ZestAssignee: gef-inbox <gef-inbox>
Status: RESOLVED FIXED QA Contact:
Severity: normal    
Priority: P3 CC: irbull, steeg
Version: unspecified   
Target Milestone: ---   
Hardware: All   
OS: All   
Whiteboard:
Attachments:
Description Flags
Cloudio Source Code and Project Files
none
Updated Unit Tests steeg: iplog+

Description Stephan Schwiebert CLA 2011-06-21 13:43:36 EDT
Build Identifier: M20110210-1200

I would like to contribute 'Cloudio', a tag cloud viewer for SWT, to Zest. It can currently be found on GitHub (https://github.com/sschwieb/Cloudio) The project wiki contains some example clouds and code snippets, but the repository  also contains an example RCP application to demonstrate the implemented features.

Reproducible: Always
Comment 1 Stephan Schwiebert CLA 2011-06-21 13:46:23 EDT
Created attachment 198352 [details]
Cloudio Source Code and Project Files

This is the complete project source code - run 'mvn clean install' in the parent project to build.
Comment 2 Fabian Steeg CLA 2011-06-21 15:21:54 EDT
Many thanks for this very nice contribution! With its customizable visualizations, JFace viewer and separate layout package it looks like a great fit for Zest. I will take a closer look at the code you attached real soon. 

In the meantime, to contribute this to Zest, we need a statement from you that you wrote this code from scratch, without referencing any non-EPL material, that you are the copyright owner and that you authorize this contribution under the EPL.
Comment 3 Stephan Schwiebert CLA 2011-06-21 15:48:20 EDT
Legal Message: 

I, Stephan Schwiebert, declare that I developed attached code from scratch, without referencing any 3rd party materials except material licensed under the EPL. I certify that I am the copyright owner and authorize this contribution.
Comment 4 Fabian Steeg CLA 2011-06-23 11:39:03 EDT
I took a closer look at your contribution and this all looks really good. The sample application is very useful for demonstrating the available features and possible use cases (e.g. image export, customized layout, etc.). The Tycho build with tests should make an integration into the Zest build easy. The only thing missing though are proper headers in the tests bundle - could you fix these and resubmit? Many thanks!
Comment 5 Stephan Schwiebert CLA 2011-06-23 15:29:27 EDT
Created attachment 198493 [details]
Updated Unit Tests

Updated Cloudio Source Code and Project Files

Thank you, Fabian - and sorry, I completely forgot about the unit tests. The updated attachment fixes this.
Comment 6 Fabian Steeg CLA 2011-06-23 17:26:34 EDT
Great, thanks Stephan - I've filed CQ 5299 for legal review.
Comment 7 Fabian Steeg CLA 2011-08-23 11:42:23 EDT
This contribution has been approved in CQ 5299. The code is now in the Zest Git repository [1] (which is mirrored on GitHub [2]). I've moved the tests to the org.eclipse.zest.tests bundle, and added the org.eclipse.zest.cloudio bundle to the Zest SDK feature, which can be installed from the nightly [3] and integration [4] Hudson jobs, and the Marketplace [5]. I've also moved the example application to the org.eclipse.zest.examples namespace to make it officially non-API code. Issues can be reported in Bugzilla [6], for discussion there's the user forum [7] and the developer list [8].

[1] http://git.eclipse.org/c/gef/org.eclipse.zest.git
[2] https://github.com/eclipse/zest
[3] https://hudson.eclipse.org/hudson/job/gef-zest-nightly/
[4] https://hudson.eclipse.org/hudson/job/gef-zest-integration/
[5] http://marketplace.eclipse.org/content/zest
[6] https://bugs.eclipse.org/bugs/enter_bug.cgi?product=GEF&component=Zest
[7] http://www.eclipse.org/forums/eclipse.tools.gef
[8] https://dev.eclipse.org/mailman/listinfo/gef-dev