Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 349950

Summary: [client] "Reload" plugin doesn't work right after installing the plugin
Product: [ECD] Orion Reporter: Mark Macdonald <mamacdon>
Component: ClientAssignee: Simon Kaegi <simon_kaegi>
Status: RESOLVED FIXED QA Contact:
Severity: normal    
Priority: P3 CC: simon_kaegi
Version: 0.2   
Target Milestone: 1.0 M2   
Hardware: PC   
OS: Windows 7   
Whiteboard:

Description Mark Macdonald CLA 2011-06-21 09:58:23 EDT 
1. Go to the Plugins page
2. Install some plugin that provides one or more services, and is hosted at some URL you control. (I used a plugin hosted from an inner site).
3. Make a change to the plugin -- eg. add some additional service properties.
4. Go back to the plugins page, click the "Reload" link on the Orion toolbar.
5. Expected to see the changed version of the plugin, but it remains the same.

If you Refresh the page in your browser after step 3, it works as expected.
Comment 1 Simon Kaegi CLA 2011-06-21 10:28:44 EDT 
Jeez a feature is not even in for one day and people are already complaining ;) I think this usecase is important at dev time but not typical in production so think hitting F5 is ok for 0.2.

What's happening here is our call to load the plugin is being ignored the second time because the plugin is marked as loaded already. What we need to do something like a force load command on the plugin.
Comment 2 Mark Macdonald CLA 2011-06-21 13:49:10 EDT 
I also noticed that if you install a plugin that fails (due to a programming error), then fix the error and try to install it again, it will fail again until you reload the page. 

Sounds like the same issue, so I'll just mention it here rather than open a new bug
Comment 3 Simon Kaegi CLA 2012-08-30 20:05:11 EDT 
This is more an implementation note and reminder to write tests for me:

Plugin states -- "uninstalled", "installed", "enabled", "loaded"
Plugin event types -- "uninstalled", "installed", enabled", "disabled", "loaded", "unloaded", "updated"
Comment 4 Simon Kaegi CLA 2012-09-25 17:11:54 EDT 
Fixed in Master