Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 349943

Summary:	[git]Git log: can not switch back to local if branch does not have a tracked remote branch.
Product:	[ECD] Orion	Reporter:	libing wang <libingw>
Component:	Client	Assignee:	Szymon Brandys <Szymon.Brandys>
Status:	RESOLVED FIXED	QA Contact:
Severity:	normal
Priority:	P3	CC:	simon_kaegi
Version:	0.2	Flags:	malgorzata.tomczyk: review+ simon_kaegi: review+
Target Milestone:	0.2
Hardware:	PC
OS:	Windows 7
Whiteboard:

Description libing wang

2011-06-21 09:27:57 EDT

Comment 1 libing wang

2011-06-21 09:32:00 EDT

In the repo page create a new branch and check out.
There is no remote branch yet.
Go to git log page for this branch , switch to remote.
You will see "no remote branch " message , which is good.
But the issue is that you can not switch back to the local log.
Reloading the page makes it worse : you can not even see the switch action.

Comment 2 Szymon Brandys

2011-06-21 09:47:49 EDT

We should:
1) Hide "Push All" and "Switch to Remote" on Git Log, if there is no remote defined for the repo (similarly we hide them on Git Status)
2) Hide "Push" action for local branches on the Git Repo page, for repos with no remotes

Comment 3 Simon Kaegi

2011-06-21 14:48:46 EDT

+1 for RC3 so long as the change is targeted and small.

Comment 4 Szymon Brandys

2011-06-22 06:40:47 EDT

Gosia, please review.

Comment 5 Malgorzata Janczarska

2011-06-22 08:01:49 EDT

Looks fine!

Comment 6 Szymon Brandys

2011-06-22 08:57:42 EDT

Fixed with c4a1b775952b7c975757ca56bbd74890fff1c6e1 and 8648022526c7fe617764270dba66070d07ce24f8.

Comment 7 Simon Kaegi

2011-06-22 09:46:20 EDT

Looks good -- glad to have this fix in.