Bug 349932

Description Knut Wannheden 2011-06-21 06:50:59 EDT

In the following piece of code from ClusteringBuilderState#doUpdate() the newDelta is registered with the newState and then also directly removed from / added to the newData. The latter is however already done in CurrentDescriptions#register() (i.e. in the call newState.register(newDelta)). So it seems like those lines could be removed. I.e. replace:

        if (newDelta != null) {
            newDeltas.add(newDelta);
            if (newDelta.haveEObjectDescriptionsChanged())
                changedDeltas.add(newDelta);
            // Make the new resource description known and update the map.
            newState.register(newDelta);
            if (newDelta.getNew() == null) {
                newData.removeDescription(changedURI);
            } else {
              newData.addDescription(changedURI, newDelta.getNew());
            }
        }

with:


        if (newDelta != null) {
            newDeltas.add(newDelta);
            if (newDelta.haveEObjectDescriptionsChanged())
                changedDeltas.add(newDelta);
            // Make the new resource description known and update the map.
            newState.register(newDelta);
        }