Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 349868

Summary: [server][git] New git repository doesn't have user.name and user.email set
Product: [ECD] Orion Reporter: John Arthorne <john.arthorne>
Component: ClientAssignee: Szymon Brandys <Szymon.Brandys>
Status: RESOLVED FIXED QA Contact:
Severity: normal    
Priority: P3 CC: bokowski, janikpiotrek, malgorzata.tomczyk, simon_kaegi, tomasz.zarna
Version: 0.2Flags: tomasz.zarna: review+
simon_kaegi: review+
Target Milestone: 0.2   
Hardware: PC   
OS: Windows 7   
Whiteboard:
Bug Depends on:    
Bug Blocks: 350012    
Attachments:
Description Flags
mylyn/context/zip none

Description John Arthorne CLA 2011-06-20 16:14:03 EDT 
0.2 RC2

1) Ensure your Git Name and Git Mail are set on the profile page
2) Init a new repository from the Repositories page
3) Perform a commit on the repository

-> Notice that the commit does not have my user name and mail that I set on the profile page in step 1). This means the user must first go to the configuration panel and add these configuration settings to each repository before they perform any commit.
Comment 1 Boris Bokowski CLA 2011-06-20 16:41:07 EDT 
(In reply to comment #0)
> This means the user must first go to the configuration
> panel and add these configuration settings to each repository before they
> perform any commit.

And they will have the bogus initial commit which is not under their name forever. I can live with the initial commit to make JGit happy but it should be under the user's name.
Comment 2 Tomasz Zarna CLA 2011-06-21 06:56:08 EDT 
Created attachment 198320 [details]
mylyn/context/zip
Comment 3 Boris Bokowski CLA 2011-06-21 09:39:23 EDT 
I find this important to fix for 0.2, if possible.
Comment 4 Szymon Brandys CLA 2011-06-21 09:54:54 EDT 
I'll take a look today.
Comment 5 Tomasz Zarna CLA 2011-06-21 10:40:14 EDT 
The proposed fix looks fine. Having a unit test would be great.
Comment 6 Szymon Brandys CLA 2011-06-21 10:45:02 EDT 
(In reply to comment #5)
> The proposed fix looks fine. Having a unit test would be great.
I raised a separate bug for moving Git Init to a task and update tests. See Bug 349952.
Comment 7 Simon Kaegi CLA 2011-06-21 12:37:50 EDT 
Pushed. For 0.3 it might be good to have a user update their profile before doing the init/commit so that the user log does not show "()", but with this fix things are now working much more closely to what I expect.