Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 349857

Summary: Update indexing and search for eglars
Product: z_Archived Reporter: Justin Spadea <jspadea>
Component: EDTAssignee: Zhi Zhu <zhuzhi>
Status: CLOSED FIXED QA Contact:
Severity: enhancement    
Priority: P3 CC: jspadea, mayunf, mheitz, pharmon, songfan, svihovec, xiaobinc, zhuzhi
Version: unspecified   
Target Milestone: ---   
Hardware: PC   
OS: Linux   
Whiteboard: EGLAR Eglar
Bug Depends on: 378433, 378441, 378621    
Bug Blocks:    

Description Justin Spadea CLA 2011-06-20 13:55:07 EDT 
Some of the indexing code for eglars was commented out and needs to be updated for EDT. See the comments in BinaryIndexer and BinaryIndexerRequestor. The class BinaryElementParser had too many problems and wasn't brought over from RBD, so that too will need to be updated. It is probably the majority of the work.

Note that you can now search for annotations and stereotypes in EDT. You'll need to make sure that they're indexed appropriately, and show up in search results. There might not be anything to do for indexing, but there probably is work for search.

In BinaryIndexerRequestor, the code that was commented out had to do with IR constants that no longer exist. You'll probably have to change how this code works, or check with Paul Harmon if the part type constants should be added to the new IR model.
Comment 1 Zhi Zhu CLA 2011-07-26 03:30:54 EDT 
The basic indexing and search flow is done, now can search record and library, other parts are not included for EGLAR part.
Comment 2 Zhi Zhu CLA 2012-04-26 01:07:54 EDT 
Declaration and Reference searches will work.
Comment 3 Zhi Zhu CLA 2012-05-04 05:00:46 EDT 
Can Search EGL Part: Service
Comment 4 Justin Spadea CLA 2012-05-04 10:28:22 EDT 
Regarding some of the changes being made for this, I saw that "EGLbin" was being changed to "EGLBin". Note that you cannot make assumptions about the output directory name, which can be whatever the user wants. You should be asking the IEGLProject for its output location instead. See IEGLProject.getOutputLocation() or AbstractProjectBuildPath.getOutputLocation().
Comment 5 Zhi Zhu CLA 2012-05-06 20:15:06 EDT 
I remembered you fired a bug for this, will fix this
Comment 6 Zhi Zhu CLA 2012-05-07 23:17:17 EDT 
IRFileStructureRequestor$enterFunction
LogicAndDataPartImpl$visitChildren
Comment 7 Zhi Zhu CLA 2012-05-08 22:40:28 EDT 
EGLSearchResultLabelProvider
Comment 8 Zhi Zhu CLA 2012-05-22 21:26:30 EDT 
resolve it
Comment 9 Justin Spadea CLA 2012-06-22 11:23:32 EDT 
Closing