Bugzilla – Full Text Bug Listing
| Summary: | Support or at least omit <source> sections | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | z_Archived | Reporter: | John Arthorne <john.arthorne> | ||||||
| Component: | Mylyn | Assignee: | David Green <greensopinion> | ||||||
| Status: | RESOLVED FIXED | QA Contact: | David Green <greensopinion> | ||||||
| Severity: | enhancement | ||||||||
| Priority: | P3 | CC: | mamacdon | ||||||
| Version: | unspecified | ||||||||
| Target Milestone: | 1.5.1 | ||||||||
| Hardware: | PC | ||||||||
| OS: | Windows 7 | ||||||||
| Whiteboard: | |||||||||
| Attachments: |
|
||||||||
While in an ideal world I would get syntax highlighted HTML, I would be quite happy if it just ommitted the <source></source> tags entirely so we can at least have nice syntax highlighting on wiki.eclipse.org. Source blocks are now implemented as a preformatted block with the appropriate CSS class. Contents of the block are emitted as characters (ie: the source is not syntax-highlighted) Created attachment 198419 [details]
mylyn/context/zip
Awesome, thanks! David, if you want to include the change in 1.5.1 you have to cherry pick the commit onto the e_3_7_m_3_6_x branch. Otherwise the milestone should be set to 1.6.0. Created attachment 198439 [details]
mylyn/context/zip
Thanks Steffen. Cherry picked, rebased to e_3_7_m_3_6_x. I'm not sure what that means but I don't see the commit on the branch. All that needs to happen is to cherry pick the commits for this task. Rebasing should not be required (and is actually harmful for pushed branches). Sorry, my bad, I was looking at the wrong thing. Looks good now! Thanks. David, did this change introduce new API? If that is the case we can not make it available in 1.5.1 but we can only apply the change for 1.6. Ag, I missed that - sorry. I can refactor it for 1.5.1 so that it doesn't involve new API, (but keeps the new API for 1.6) Removed new API in 1.5.1 on branch e_3_7_m_3_6_x and fixed @since tag on new api on branch master (set to 1.6) that should be it for this one. for future reference, versioning should follow "these guidelines":http://wiki.eclipse.org/Version_Numbering which require the minor segment to change whenever there are externally visible changes (eg: API additions) Thanks David. If you set an API baseline you can easily detect these type of errors in your workspace. |
The eclipse wiki has the wikimedia syntax highlighting extension installed. This allows you to write blocks like this: <source lang="javascript"> var serviceImpl = { run: function(text) { return text.split("").reverse().join(""); } }; </source> And have it syntax highlighted like javadoc. Currently WikiText converts this to: <p><source lang="javascript"></p> <pre> var serviceImpl = { run: function(text) { return text.split("").reverse().join(""); } }; </pre> <p></source></p>