Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 349717

Summary: Server validation messages incorrectly removed in New Server wizard
Product: [WebTools] WTP ServerTools Reporter: Steven Hung <sghung>
Component: wst.serverAssignee: Elson Yuen <eyuen7>
Status: RESOLVED FIXED QA Contact: Angel Vera <arvera>
Severity: normal    
Priority: P3 CC: eyuen7, vladislav.iliev
Version: unspecified   
Target Milestone: 3.2.5   
Hardware: PC   
OS: Windows XP   
See Also: https://git.eclipse.org/r/109055
Whiteboard:
Attachments:
Description Flags
Path proposed
eyuen7: iplog+
v1.0 none

Description Steven Hung CLA 2011-06-17 14:25:20 EDT 
Build Identifier: 3.6.2 M20110210-1200

In org.eclipse.wst.server.ui.internal.wizard.page.NewManualServerComposite.handleHostnameChange(IServerType), both methods checkHostAndServerType and updateRuntimeCombo are cleaning up the wizard validation messages before validation. Currently, the validation messages in checkHostAndServerType are being removed.

Reproducible: Always

Steps to Reproduce:
1. File > New > Other... > Server
2. Enter a remote server host name (for example "localhost2")
3. Click on Apache > Tomcat v6.0 server from the type list
4. The validation message "The currently selected server type does not support remote hosts" appears in the wizard page
5. If I type remote host name into the server host name, the validation message incorrectly disappears, and only returns when I click on another server type and click back to the server

Expected result: the validation message should not be removed
Comment 1 Vladislav Iliev CLA 2011-07-15 06:51:27 EDT 
Created attachment 199737 [details]
Path proposed

Path proposed. Now the previously set error  validation message is not cleared.
Comment 2 Elson Yuen CLA 2011-07-26 13:45:11 EDT 
The patch looks good in general.  The only minor change that I'll made to the patch is to return false if IServerType is false on the method org.eclipse.wst.server.ui.internal.wizard.page.NewManualServerComposite.checkHostAndServerType(IServerType).
Comment 3 Elson Yuen CLA 2011-07-26 13:46:40 EDT 
Created attachment 200383 [details]
v1.0

Based on the original patch, I have updated with a newer version with the change described on my previous comment.
Comment 4 Elson Yuen CLA 2011-07-26 17:16:54 EDT 
Code dropped to 32M, 33M and HEAD
Comment 5 Eclipse Genie CLA 2017-10-11 16:36:52 EDT 
New Gerrit change created: https://git.eclipse.org/r/109055