Bugzilla – Full Text Bug Listing
| Summary: | NPE due to password case sensitivity change | ||||||
|---|---|---|---|---|---|---|---|
| Product: | [ECD] Orion | Reporter: | John Arthorne <john.arthorne> | ||||
| Component: | Client | Assignee: | John Arthorne <john.arthorne> | ||||
| Status: | RESOLVED FIXED | QA Contact: | |||||
| Severity: | major | ||||||
| Priority: | P3 | CC: | Szymon.Brandys | ||||
| Version: | 0.2 | Flags: | Szymon.Brandys:
review+
|
||||
| Target Milestone: | 0.2 | ||||||
| Hardware: | PC | ||||||
| OS: | Windows 7 | ||||||
| Whiteboard: | |||||||
| Attachments: |
|
||||||
I think the only possibility is that "login" is null. Created attachment 198203 [details]
Fix v01
I have entered bug 349719 to investigate why this isn't being caught earlier. Ideally the dialog would not even POST to the server if the user has not provided a login. However this null check is still worthwhile. |
I'm seeing a ton of errors like this in the log on orion.eclipse.org. This is related to the change to support case-insensitive passwords. java.lang.NullPointerException: null at org.eclipse.orion.internal.server.user.securestorage.SecureStorageCredentialsService.findNodeIgnoreCase(SecureStor ageCredentialsService.java:201) ~[na:na] at org.eclipse.orion.internal.server.user.securestorage.SecureStorageCredentialsService.getUser(SecureStorageCredenti alsService.java:167) ~[na:na] at org.eclipse.orion.internal.server.user.securestorage.SecureStorageCredentialsService.getUser(SecureStorageCredenti alsService.java:1) ~[na:na] at org.eclipse.orion.server.authentication.form.core.FormAuthHelper.getUserForCredentials(FormAuthHelper.java:134) ~[ na:na] at org.eclipse.orion.server.authentication.form.core.FormAuthHelper.performAuthentication(FormAuthHelper.java:104) ~[ na:na] at org.eclipse.orion.server.authentication.form.servlets.LoginServlet.doPost(LoginServlet.java:46) ~[na:na]