Bugzilla – Full Text Bug Listing
| Summary: | [client] Remove /org.dojotoolkit dependency from examples | ||
|---|---|---|---|
| Product: | [ECD] Orion | Reporter: | Mark Macdonald <mamacdon> |
| Component: | Client | Assignee: | Project Inbox <e4.orion-inbox> |
| Status: | RESOLVED FIXED | QA Contact: | |
| Severity: | normal | ||
| Priority: | P3 | CC: | simon_kaegi |
| Version: | 0.2 | Flags: | simon_kaegi:
review+
|
| Target Milestone: | 0.2 | ||
| Hardware: | PC | ||
| OS: | Windows 7 | ||
| Whiteboard: | |||
Here is a patch: http://git.eclipse.org/c/e4/org.eclipse.orion.client.git/commit/?h=bug349705 It uses Dojo 1.6 from Google's CDN and removes the dojo/dijit stylesheets. Adds a CSS rule to make the font & spacing in the examples look the same as before. Removed the CDN link due to legal questions. I'll just use this bug to remove the imports of Dojo css files, so the examples will load a bit faster. |
The examples (embeddededitor.html, minimaleditor.html) are picking up dojo through > <script type="text/javascript" src="/org.dojotoolkit/dojo/dojo.js.uncompressed.js"></script> This is not consumable, since it assumes that the server you're running the example on will have dojo available at that path. We should: - Reference a CDN copy of dojo for the examples. - Remove CSS imports of dojo stylesheets from the examples. (They're causing a long chain of requests that increases the page load time substantially.)