Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 349704

Summary:	[client][log] Should render outgoing changes when there is no remote branch.
Product:	[ECD] Orion	Reporter:	libing wang <libingw>
Component:	Git	Assignee:	Malgorzata Janczarska <malgorzata.tomczyk>
Status:	CLOSED WORKSFORME	QA Contact:
Severity:	normal
Priority:	P3	CC:	bokowski, john.arthorne, malgorzata.tomczyk, simon_kaegi, Szymon.Brandys
Version:	unspecified
Target Milestone:	1.0
Hardware:	PC
OS:	Windows 7
Whiteboard:

Description libing wang

2011-06-17 12:22:57 EDT

In bug 349106 , as Gosia mentioned at comment 4 as solution:
The problem is that the new local branch doesn't have a remote branch. In this
case I think we should display the mini log for local branch and the remote
should remain empty with information "no remote branch".

I agree with the solution. It seems that after I push something from local branch to remote , the remote branch is there.

But how do I know I have to push something without seeing the outgoing changes?

I have a real work flow here for code review:
1.Change my code on local master.
2.Create a new local branch.
3.Commit my changes to the local branch.
4. Push changes to remote .
After step 3 , I was supposed to see the outgoing changes but I only saw that commit without the "outgoing change" mark.
Same thing happens when I go to "complete log".
The good thing is that if I "push all" in the complete log page I can still do it.

I am opening this bug because the push command in status page is checking the outgoing changes to decide render or not. Should I just enable it without checking it ?

Comment 1 Szymon Brandys

2011-06-17 12:52:30 EDT

If there is a local branch with no corresponding remote branch, push will create the remote branch. We should show the decoration for all commits in this case, so the user knows that all changes will be pushed to the newly create remote branch.

Comment 2 libing wang

2011-06-17 12:55:20 EDT

(In reply to comment #1)
> If there is a local branch with no corresponding remote branch, push will
> create the remote branch. We should show the decoration for all commits in this
> case, so the user knows that all changes will be pushed to the newly create
> remote branch.

As this is targeted for 0.3 I will just always enable push action in git status page for 0.2.

Comment 3 Boris Bokowski

2011-06-17 15:26:55 EDT

(In reply to comment #2)
> As this is targeted for 0.3 I will just always enable push action in git status
> page for 0.2.

+1 for the workaround in Libing's code (which I have reviewed).

Comment 4 libing wang

2011-06-17 15:47:49 EDT

I have pushed the workaround with a8c7fcdbfd69eabd43b874dc2330a6df45199400

Comment 5 Simon Kaegi

2011-06-17 17:56:13 EDT

(In reply to comment #1)
> If there is a local branch with no corresponding remote branch, push will
> create the remote branch. We should show the decoration for all commits in this
> case, so the user knows that all changes will be pushed to the newly create
> remote branch.

I had something like this case while testing today. If this is not a tracking branch we still need someway to identify a particular origin server otherwise how do we know which remote server to push the new branch to.

Comment 6 John Arthorne

2011-10-20 15:59:06 EDT

This appears to be working fine for me, but I might be misunderstanding. Szymon I leave it to you to close if appropriate.

Comment 7 Malgorzata Janczarska

2012-10-10 05:59:01 EDT

It looks like it works fine now.