Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 349674

Summary: Reject NavigationNodes without NavigationNodeIds
Product: [RT] Riena Reporter: Steffen Kriese <steffen.kriese>
Component: navigationAssignee: Project Inbox <riena.core-inbox>
Status: NEW --- QA Contact:
Severity: normal    
Priority: P3    
Version: unspecified   
Target Milestone: 4.0.0.0   
Hardware: PC   
OS: All   
Whiteboard:

Description Steffen Kriese CLA 2011-06-17 07:51:50 EDT
Riena assumes that every NavigationNode is unique, that means it is identified by its NavigationNodeId. But at the moment it is possible to create a NavigationNode without a NavigsationNodeId or pass in null. Those nodes can't be found in the navigationtree by using methods like NavigationNode.findNode() and can lead to other problems described in Bug #349504.

In my opinion we do a fail fast and reject this, by throwing a RuntimeException if the NavigationNodeId is null at any point.

Any thoughts or comments on this?