Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 349641

Summary:	Layout of editor.actions is a bit off
Product:	[ECD] Orion	Reporter:	Simon Kaegi <simon_kaegi>
Component:	Client	Assignee:	Susan McCourt <susan>
Status:	RESOLVED FIXED	QA Contact:
Severity:	normal
Priority:	P3	CC:	bokowski
Version:	0.2
Target Milestone:	0.4 RC1
Hardware:	PC
OS:	Windows 7
Whiteboard:

Description Simon Kaegi

2011-06-16 22:52:21 EDT

I noticed that layout for editor actions seemed a bit strange. First, after adding an editor action there is a new white bar very close to the save button. Second I don't see icons. Perhaps we decided we only wanted text here??

Comment 1 Boris Bokowski

2011-06-17 09:07:21 EDT

Yes I think we decided only text in the toolbar.

Comment 2 Susan McCourt

2012-01-30 18:10:18 EST

compare editors are still showing the editor action icon vs. text.  Need to fix that.  Will do a pass once we have a reasonable guideline we can explain for when icons are used in the toolbar and how the developer can force an icon.

Comment 3 Susan McCourt

2012-02-03 02:41:58 EST

(In reply to comment #2)
> compare editors are still showing the editor action icon vs. text.  Need to fix
> that.  Will do a pass once we have a reasonable guideline we can explain for
> when icons are used in the toolbar and how the developer can force an icon.

For now we use text unless there is none specified (not common).
I also noticed that the old separator gif was not showing (it was white on white).  Changed it to be gray.  It needs some polish, tracked in bug 370481.

Comment 4 Susan McCourt

2012-02-03 03:57:10 EST

pushed fix.