Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 349634

Summary: [client] page layout and visual styling for 0.4
Product: [ECD] Orion Reporter: Susan McCourt <susan>
Component: ClientAssignee: Susan McCourt <susan>
Status: RESOLVED FIXED QA Contact:
Severity: normal    
Priority: P3 CC: antonm, john.arthorne, johnjbarton, lindawat, Silenio_Quarti, simon_kaegi
Version: 0.2   
Target Milestone: 0.4 M2   
Hardware: PC   
OS: Windows 7   
Whiteboard:
Attachments:
Description Flags
mockup from 1/25/2012 none

Description Susan McCourt CLA 2011-06-16 18:45:10 EDT
Notes from a visual design review with Linda.
Some of these might have been easy CSS changes in the dojo theme, I just couldn't find the precise CSS rules at the last minute.  Others of these might require more consideration.

Nav-like styling
- tighten up the width of the toggle splitter to flush the arrow to the edge.  Also consider a splitter that is even thinner and fattens up on hover (would have to see how this plays.)
- put a border around the push button menus on hover.  We tried this, but it caused the layout to shift in the toolbar and header.  Putting a transparent border for the non-hover case didn't help, but I might have been using the wrong dijit CSS rule.
- add some pixels of padding to the right of the menu arrow (as in the More menu) so that there is as much padding on the right as on the left (again, I found some dijit CSS for padding but couldn't get it working.)
- similarly, the "More>" in the toolbar doesn't baseline align with the text links.  I haven't figured out the CSS rules in dijit that would fix this
- consider getting rid of the alternating bands in the navigator list
- revisit the design of the footer, it's pretty plain
- revisit the treatment for favorites underlining and how far it spans
- revisit color strategy for text (we have lots of different shades of gray, tighten this up, etc.)

Editor styling
- fonts in editor (moving to a more modern fixed width font like Consolas in windows)
- editor syntax highlighting colors
- selected line color in editor
- selection block color in editor
- pushing back the line numbers, getting rid of border on ruler
- do we want a different problem marker
Comment 1 Susan McCourt CLA 2011-10-27 13:31:31 EDT
need to revisit this list during 0.4 work
Comment 2 Susan McCourt CLA 2011-11-28 15:17:38 EST
generalizing this title.
We are looking for a "fresh coat of paint" for 0.4, so we want to take a step back and freshen up the common page elements (banner, etc.) first before drilling in on these details.

other points to consider:

- visual affordance for toggling the banner out of view (or should we design a reduced banner that would still have the breadcrumb, etc.)
- mobile friendliness
Comment 3 Susan McCourt CLA 2011-12-02 11:44:35 EST
In bug 363740 we talked about making the search box wider, to show scoping information.  Consider this when we redo layouts.
Comment 4 Susan McCourt CLA 2011-12-02 11:45:16 EST
general discussion of new styling for 0.4:

http://wiki.eclipse.org/Orion/Page_Layout
Comment 5 John J. Barton CLA 2011-12-02 12:54:40 EST
(In reply to comment #4)
> general discussion of new styling for 0.4:
> 
> http://wiki.eclipse.org/Orion/Page_Layout

The ken missing item for me might be called "Context sensitive navigation". On the edit page for foo.js I want the git status link for the project foo.js lives in; on the git status page I want the navigation link for the project.
Comment 6 John J. Barton CLA 2011-12-02 12:57:12 EST
The multi-file copy/move UI is obscure. First you have to know the click the box on a file, then notice a new menu, mouse to it, then it almost never has the dest folder list, you have to use the tedious dialog version.
Comment 7 Susan McCourt CLA 2011-12-02 13:15:55 EST
(In reply to comment #5)
> (In reply to comment #4)
> > general discussion of new styling for 0.4:
> > 
> > http://wiki.eclipse.org/Orion/Page_Layout
> 
> The ken missing item for me might be called "Context sensitive navigation". On
> the edit page for foo.js I want the git status link for the project foo.js
> lives in; on the git status page I want the navigation link for the project.

Thanks, John.  I agree this is very important, but I feel like we covered this (mentioning those examples and bugs) in "Links to related pages" and "Related task Links".  

(In reply to comment #6)
> The multi-file copy/move UI is obscure. First you have to know the click the
> box on a file, then notice a new menu, mouse to it, then it almost never has
> the dest folder list, you have to use the tedious dialog version.

Agree.  making move/copy locally available (next to the item) used to perform too badly, but I've since fixed that problem.  Opened bug 365463 to look at it again.  There's also drag/drop (bug 339144) but no one is working on it.
Comment 8 John J. Barton CLA 2011-12-02 13:27:12 EST
(In reply to comment #7)

> Thanks, John.  I agree this is very important, but I feel like we covered this
> (mentioning those examples and bugs) in "Links to related pages" and "Related
> task Links". 

Yes, sorry I read the top of the page as "plan" not realizing it was "old" and "plan" was further down.
Comment 9 Susan McCourt CLA 2012-01-06 13:43:44 EST
(In reply to comment #8)
> (In reply to comment #7)
> 
> > Thanks, John.  I agree this is very important, but I feel like we covered this
> > (mentioning those examples and bugs) in "Links to related pages" and "Related
> > task Links". 
> 
> Yes, sorry I read the top of the page as "plan" not realizing it was "old" and
> "plan" was further down.

I moved the historical stuff to its own document.  The wiki now focuses on what we plan to do.  Also blogged about it http://adventuresinthoughtlessness.blogspot.com/2012/01/anatomy-of-orion-page.html
Comment 10 John J. Barton CLA 2012-01-10 14:00:56 EST
I believe I am running I20120108-2230

I still think that Navigate-this-project is a top level operation on a Git repo, more so than Git Log (which should be a toolbar option from Git Status IMO). 

I like the less gray UI (thanks!) but now I feel that the visuals are dominated by the rectangular menu icons.
Comment 11 Susan McCourt CLA 2012-01-26 12:41:04 EST
Created attachment 210135 [details]
mockup from 1/25/2012

per the Orion call, here is the latest screenshot of designer mockups.  I'm trying to get closer to this for M2 (darker banner, flatter toolbar and slideout, etc.).  

This will continue to change, and we have not yet drilled down on command rendering inside pages (icon vs. button vs. links).

Another disclaimer is that this mockup makes no sense from a content point of view, it's attempting to show the visuals for everything in one page.
Comment 12 Susan McCourt CLA 2012-01-26 15:56:54 EST
pushed the first set of changes that go with the mockup.
Still work to do on section headings, etc.
But this gets the basics working with respect to dark top, toolbars matching their interior panes, etc.
Comment 13 Susan McCourt CLA 2012-01-26 19:28:37 EST
Marking fixed.
I've committed the last of the structural changes for the mockup, moving the progress, status, and notification messages out of the footer and into a sliding area under the tools.

There will still be visual tweaks on colors, spacing, etc. but I'll track these in other bugs.

The biggest piece not done is surrounding headers, commands, etc. and that is covered in bug 360986