Bugzilla – Full Text Bug Listing
| Summary: | [Tests] EMF runtime compatibility issue and duplicate code in test models | ||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | [Modeling] EMF | Reporter: | Victor Roldan Betancort <vroldanbet> | ||||||||||||||
| Component: | cdo.core | Assignee: | Victor Roldan Betancort <vroldanbet> | ||||||||||||||
| Status: | CLOSED FIXED | QA Contact: | Eike Stepper <stepper> | ||||||||||||||
| Severity: | normal | ||||||||||||||||
| Priority: | P3 | CC: | martin.fluegge | ||||||||||||||
| Version: | 4.1 | Flags: | stepper:
review+
|
||||||||||||||
| Target Milestone: | --- | ||||||||||||||||
| Hardware: | PC | ||||||||||||||||
| OS: | Windows 7 | ||||||||||||||||
| Whiteboard: | |||||||||||||||||
| Attachments: |
|
||||||||||||||||
|
Description
Victor Roldan Betancort
Created attachment 198136 [details]
patch v1
- changed all genmodels to target 2.6
- regenerated mango and model3
- removed duplicate code
Created attachment 198225 [details]
Patch Dawn v1
Sorry, it took a bit longer, because I was (and still am) fighting with SWTBot to bring up some reliable UI tests for the code generation. But manual testing looks good, so here is the patch for Dawn.
With CDO 4.0 released, I think we can now commit both patched. We should also raise a maintenance bug for this issue to have the fix in Indigo SR1. Eike, what do you think? I have to reject both patches as they both create version errors. Guys, please install the version tool I've developed with a lot of effort. It will clearly tell you where to increase manifest versions. Martin, you even overlooked API errors. Created attachment 199199 [details]
Patch Dawn v2
I corrected the error.
In my defence: When we applied the patches, CDO 4.0 GA was not yet released. So we were still operating on the 3.0 API Baseline. There was no chance to detected those errors in advance ;)
I see ;-) Martin, I suppose your v1 patch is obsolete? Created attachment 199201 [details]
Patch Dawn v3
...with warnings removed...
(In reply to comment #3) > With CDO 4.0 released, I think we can now commit both patched. > We should also raise a maintenance bug for this issue to have the fix in Indigo SR1. This confuses me. Is this a 4.0 bugzilla or not? Is this version value correct? This bugzilla was a 4.0 bug and was raised when we worked on 4.0. But we did not manage to fix before the release. It seems that we did miss to change the version number. But we need to fix this issue for 4.0 and 4.x, at least that is what I think. So, what version do I have to apply the patches against? Correction. This on cannot be a maintenance issue, because fixing it breaks the API. So the Dawn patch has to be applied against HEAD only. I think this one is confusing because we are tracking the same issue on CDO and Dawn. Since Dawn requires a major version switch, I fear that CDO need follow likewise. Vik, is this correct? Do we need to change to CDO 5.0 or are changes in the test models not that problematic. (In reply to comment #12) > Correction. This on cannot be a maintenance issue, because fixing it breaks the > API. So the Dawn patch has to be applied against HEAD only. I see. > I think this one is > confusing because we are tracking the same issue on CDO and Dawn. Cany ou please factor out a new bug, so that we can clone one of them to 4.0 maintenance? > Since Dawn requires a major version switch, I fear that CDO need follow > likewise. Not necessarily because the CDO (model repoitory) plugins do not depend and reexport Dawn plugins. Major tests versions should never be impacted because I've made all tests internal (did I miss any?). (In reply to comment #13) > Cany ou please factor out a new bug, so that we can clone one of them to 4.0 > maintenance? > I filed Bug 352823 and attached Dawn patch v3. I assigned this one to Vik, that he can continue on the CDO changes he already started. > Major tests versions should never be impacted because > I've made all tests internal (did I miss any?). I see. Then there should be no problem for CDO ;) I believe it breaks API because of the Dawn plugins, not because our test-framework. If you generated to EMF 2.7 runtime, a user may extend it and rely on, for instance of EMF new Switch mechanism. So yeah, this doesn't break CDO APIs, because it only affects test-plugins. What's the state of the patch? Is it deprecated? If so, I'll factor out CDO changes, provide a new one, and wait for review According to GIT, my repo is up to date so... I assume the current patch is valid, is that right? Sorry guys, this last comment was meant to be in another bug. Consequences of multitasking ;)
> What's the state of the patch? Is it deprecated?
As far as I remember Eike found some version errors in the patch.
Ah, yeah, that's because I was not using his wonderful versioning tool :P Created attachment 200176 [details]
patch v2
fixed versioning issues
Vik, please commit eventually. Eike, could you commit? Im out of the office until 8th august. Thanks! Committed revision 8817 for Vik. Do we want this in 4.0? Eike, Yes, since im not allowed to migrate to 4.1, id appreciate that! 4.0 Fix is in bug 353180. Not all package export versions have been properly updated here. Created attachment 200430 [details]
Additional manifest fix
Committed revision 8828 Closing. |