Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 349592

Summary:	Can't see (or paste into) dialogs on iPad
Product:	[ECD] Orion	Reporter:	Mike Wilson <Mike_Wilson>
Component:	Client	Assignee:	Project Inbox <orion.client-inbox>
Status:	RESOLVED WONTFIX	QA Contact:
Severity:	normal
Priority:	P3	CC:	bokowski, simon_kaegi, susan
Version:	0.2	Keywords:	usability
Target Milestone:	---
Hardware:	Other
OS:	iOS
Whiteboard:
Bug Depends on:
Bug Blocks:	339427

Description Mike Wilson

2011-06-16 12:16:16 EDT

The dojo dialogs we are running seem to all try to center themselves on the screen. On the iPad this means that they are hidden behind the pop up keyboard. This makes it difficult to see what you are typing, but also makes it impossible to do the "tap in it while it already has focus" gesture that allows you to get the pop up menu.

Is there any way to disable the default dojo behavior?

Comment 1 Boris Bokowski

2011-06-16 15:00:02 EDT

Longer term we should try to avoid dialogs altogether.

Comment 2 Susan McCourt

2011-06-16 20:24:32 EDT

I had code that repositioned dialogs closer to the dom element that launched them, so I know we can change this.  It requires a common mixin class (which we now have). 

The problem is that dojo has no smarts for dealing with dialogs that go off the screen, pinning to the visible border, etc.  So centering is the "safest" way to make sure everything is visible.

Of course, not using dialogs is even safer.  See bug 342739.
If we are always inserting into the dom vs. overlaying, we'd be better off.

Comment 3 Susan McCourt

2011-10-31 15:36:46 EDT

if you have a dialog open, you can't touch anywhere to close it. 
see also http://bugs.dojotoolkit.org/ticket/13488

Comment 4 Susan McCourt

2012-02-02 13:47:23 EST

let's gut check in RC2 how we are doing now on iPad

Comment 5 Susan McCourt

2012-02-16 12:06:34 EST

part of RC3 testing

Comment 6 Susan McCourt

2012-02-24 20:47:07 EST

still the same story as before, i think the idea is to get rid of dialogs where we can use slideouts, etc.

For those dialogs left, we should spend the time to:
- position them closer to the dom node involved, or at least try to get them near the top to be more ipad friendly
- we should use the workaround mentioned in http://bugs.dojotoolkit.org/ticket/13488 to make non dialogs draggable and thus closeable on an ipad.  If we need draggable for other reasons, then we need to put cancel buttons in.

Comment 7 Susan McCourt

2012-04-19 14:21:37 EDT

we should look at this after we move to dojo 1.7

Comment 8 Susan McCourt

2012-05-18 15:29:50 EDT

moving out of 0.5M2 to 0.5 milestone until we have more specific buckets for future

Comment 9 John Arthorne

2015-05-05 14:50:55 EDT

Closing as part of a mass clean up of inactive bugs. Please reopen if this problem still occurs or is relevant to you. For more details see:

https://dev.eclipse.org/mhonarc/lists/orion-dev/msg03444.html