Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 349584

Summary:	Rename refactoring doesn't work with STRING Type
Product:	[Modeling] TMF	Reporter:	Veit Hoffmann <vhoff>
Component:	Xtext	Assignee:	Jan Koehnlein <jan>
Status:	CLOSED FIXED	QA Contact:
Severity:	normal
Priority:	P3	CC:	jan, sebastian.zarnekow, tmf.xtext-inbox
Version:	unspecified	Flags:	sebastian.zarnekow: indigo+
Target Milestone:	SR1
Hardware:	PC
OS:	Windows 7
Whiteboard:

Description Veit Hoffmann

2011-06-16 11:32:37 EDT

Build Identifier: 2.0.0.v201105030849

If the key attribute of an element is encoded as org.eclipse.xtext.common.Terminals::STRING the rename refactoring converts the the value of the key attribute to ID. This breaks the parsetree.

This only happens in the declaration of the element. All other occurences of the String are refactored correctly.   


Reproducible: Always

Steps to Reproduce:
1. Change example DSL to 'Hello' name=STRING '!';
2. Enabale refactoring
3. Refactor name

Comment 1 Sebastian Zarnekow

2011-06-16 11:36:22 EDT

Does this still happen with the latest builds?

Comment 2 Veit Hoffmann

2011-06-17 05:30:35 EDT

This behavior still holds true for the current Xtext Version on the Indigo Update Site: 2.0.0.v201106010845 and current nightly buid 2.0.0.v201106050907

Comment 3 Jan Koehnlein

2011-07-05 09:17:12 EDT

We have to use the value converter in the refactoring strategy.

Fix pushed to MASTER.

Comment 4 Karsten Thoms

2017-09-19 17:53:05 EDT

Closing all bugs that were set to RESOLVED before Neon.0

Comment 5 Karsten Thoms

2017-09-19 18:03:48 EDT

Closing all bugs that were set to RESOLVED before Neon.0