Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 349558

Summary:

Engine will cyclically accept the same type more then once

Product:

[WebTools] JSDT

Reporter:

Ian Tewksbury <itewksbu>

Component:

General

Assignee:

Project Inbox <jsdt.javascript-inbox>

Status:

CLOSED INVALID

QA Contact:

Nitin Dahyabhai <thatnitind>

Severity:

normal

Priority:

Version:

3.2.5

Target Milestone:

---

Hardware:

All

OS:

All

Whiteboard:

Attachments:

Description	Flags
Patch	none

Description Ian Tewksbury

2011-06-16 09:25:34 EDT

Currently the Engine implementation will accept a type, and then when it calls the lookupEnviorment#buildTypeBindings it can accept that type again.  This duplicate work should be prevented.

Comment 1 Ian Tewksbury

2011-06-16 09:27:56 EDT

Created attachment 198095 [details]
Patch

patch to prevent the cyclic accepting of units.  Passes all existing JUnits.

Comment 2 Ian Tewksbury

2011-06-16 09:50:22 EDT

It seems this patch breaks some of the JUnits I have written for Bug 306958

Comment 3 Ian Tewksbury

2011-06-16 10:07:55 EDT

I guess this fix will have to hold off.  It seems for some reason if we prevent this cycle then the return types for constructors in files other then the one content assist is being invoked for do not get set.

Comment 4 Ian Tewksbury

2011-06-16 12:32:42 EDT

Chris tells me this has been done on purpose...