Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 349553

Summary:	Java compiler warning - redundant modifier
Product:	[Eclipse Project] JDT	Reporter:	Nikolay Metchev <nikolaymetchev>
Component:	Core	Assignee:	JDT-Core-Inbox <jdt-core-inbox>
Status:	RESOLVED WONTFIX	QA Contact:
Severity:	enhancement
Priority:	P3	CC:	amj87.iitr, markus.kell.r, Olivier_Thomann
Version:	3.7
Target Milestone:	---
Hardware:	PC
OS:	Windows 7
Whiteboard:

Description Nikolay Metchev

2011-06-16 08:34:27 EDT

It would be good to be able to configure the compiler to emit warnings on redundant modifiers (such as public on interface fields).

Comment 1 Ayushman Jain

2011-06-16 10:46:44 EDT

I don't think its a very good idea to have the compiler emit such specific warnings. I think its better if other static analysis tools such as FindBugs, etc do this. Too much fine grained analysis will unnecessary slow down the compiler even for those who don't stand to gain anything from such a warning.

Comment 2 Nikolay Metchev

2011-06-16 10:54:00 EDT

Surely if you set the setting to "Ignore" then there should be no slow down. Unless you are telling me that the compiler evaluates all warnings/errors regardless of the level they are set to.

Comment 3 Markus Keller

2011-06-16 11:15:19 EDT

The redundant modifiers don't harm other than being redundant, and a warning for them would rarely help finding a real problem in the vicinity. I think the Clean Up / Save Action from bug 267335 would be good enough to deal with this.

Comment 4 Ayushman Jain

2011-06-20 09:48:44 EDT

(In reply to comment #3)
> The redundant modifiers don't harm other than being redundant, and a warning
> for them would rarely help finding a real problem in the vicinity. I think the
> Clean Up / Save Action from bug 267335 would be good enough to deal with this.

+1 for a clean up.

Closing this as WONTFIX.