Bugzilla – Full Text Bug Listing
| Summary: | ti.catalog.c2800.init.Boot.xs this.$logError() needs to be updated | ||||||
|---|---|---|---|---|---|---|---|
| Product: | [Technology] RTSC | Reporter: | Karl Wechsler <karl> | ||||
| Component: | Platforms | Assignee: | Scott Gary <sg> | ||||
| Status: | CLOSED FIXED | QA Contact: | |||||
| Severity: | normal | ||||||
| Priority: | P1 | CC: | d-russo, dfriedland | ||||
| Version: | unspecified | ||||||
| Target Milestone: | --- | ||||||
| Hardware: | All | ||||||
| OS: | All | ||||||
| Whiteboard: | target:3.23.04 | ||||||
| Attachments: |
|
||||||
- fixed in platform-n08 Usually in a module's function, 'this' refers to that module. However, in this case, a module function is invoked from a private capsule function without setting 'this' to the module. As a consequence, 'this' stays a reference to a capsule, and cannot be used as a parameter to $logError. Sasa fixed the 'this' vs 'BIOS' problem, so it's not fair to mark this verify-fail, but I'm going to anyway since there's a 2nd issue.
I think the last parameter of all the logError() calls in this Boot.xs file needs to specify the module name followed by the short field name instead of the single long name shown today. This is necessary so that xgconf will show the error or warning as appropriate.
There are several examples of this in the Boot.xs file.
I think this:
Boot.$logWarning("\nPLL configuration is not supported for this PLL " +
"type. Setting configurePll to true will have no effect.",
"ti.catalog.c2800.init.Boot.configurePll");
should be change to this:
Boot.$logWarning("\nPLL configuration is not supported for this PLL " +
"type. Setting configurePll to true will have no effect.", Boot,
"configurePll");
Looking at the Boot.xs file (in platform-n20/src/ti/catalog/c2800/init), this has already been fixed by someone:
Boot.$logWarning("\nPLL configuration is not supported for this PLL " +
"type. Setting configurePll to true will have no effect.", Boot,
"configurePll");
I also looked at this in XGCONF and see the correct behavior.
Moving to RESOLVED...
xdctools 3.23.05 GA is available from here: http://www.sanb.design.ti.com/tisb_releases/XDCtools/3_23_05_61/ |
Created attachment 198062 [details] picture of the problem See attached .ppt. I think that this.$logError should be changed to BIOS.$logError().