Bugzilla – Full Text Bug Listing
| Summary: | org.pushingpixels.trident is a common bundle that should be in Orbit | ||
|---|---|---|---|
| Product: | [Tools] Orbit | Reporter: | David Williams <david_williams> |
| Component: | bundles | Assignee: | Christian Campo <christian.campo> |
| Status: | VERIFIED FIXED | QA Contact: | |
| Severity: | normal | ||
| Priority: | P3 | CC: | christian.campo, erdal.karaca.de, john.arthorne, nobody, pwebster, yves.yang |
| Version: | unspecified | ||
| Target Milestone: | Kepler RC2 | ||
| Hardware: | PC | ||
| OS: | Linux | ||
| Whiteboard: | |||
|
Description
David Williams
John, can we get this into Orbit? PW If this is required by 4.2 or e4, I would volunteer. It doesn't seem part of Eclipse 4.2, but assume its part of the remaining incubating components of e4. I looked at build I20120125-2200 (eclipse-e4-repo-incubation-I20120125-2200.zip) and it is required by (only) org.eclipse.e4.xwt. So ... whose in charge of "org.eclipse.e4.xwt" ? Does it happen to be an existing Orbit committer? If not, and if XWT is important for e4 ... (FYI, the version of org.pushingpixels.trident used in the Eclipse Incubator does not have "src" exports defined correctly in build.properties (I'm guessing, as there is an extra "src" directory created when imported) ... all the more reason to have a "correct" version in Orbit). FYI, at e4 call today (1/26) it was confirmed XWT is "still in the build", but was not active and seemed to be some question if it would stay in the build. Also, I check CQs, from while it is hard to search that database, I could only find 2 CQs for Trident ... one from e4, and another from Riena. So ... I've sent email to Christian to see if Riena interested/able to stepping up. If not, I'm fine closing this bug as "not important" and let things work themselves out as they will. Riena is activly using pushingpixels and will continue to do so. I am not an Orbit committer (none of the Riena committers is). But I am volunteering to become one and move pushingpixels to Orbit. Maybe I move also some other Riena bundles to Orbit once I am committer. :-) My understanding is that it would be cool to do that as soon as possible but its not a pressing issue. I guess I need someone to point me to rules and build process and that kind of stuff for Orbit, but I am sure David has some nice pointers or wiki pages for new committers. For starters do I need a new CQ to move it or how does that work ? I guess first of all you need to start the voting for being Orbit committer or is there a different process for Orbit ? (In reply to comment #4) > Riena is activly using pushingpixels and will continue to do so. I am not an > Orbit committer (none of the Riena committers is). > > But I am volunteering to become one and move pushingpixels to Orbit. Maybe I > move also some other Riena bundles to Orbit once I am committer. :-) > Thanks Christian! I've started the committer nomination/vote cycle. You'll want to be sure to subscribe to the orbit-dev list. The main document for "how to" add bundles to Orbit http://wiki.eclipse.org/Adding_Bundles_to_Orbit (which, IMHO, is the best guide to adding bundles to Orbit, though there are some shorter one, meant to provide a bit more of a "checklist" approach). You might also browse though the whole category of Orbit docs, to see if any appear relevant or interesting to you. http://wiki.eclipse.org/Category:Orbit Once you get to point of adding it to Orbit, there are many willing helpers on the orbit-dev list that can help with specific questions or issues that may come up. Thanks again! (In reply to comment #4) > > For starters do I need a new CQ to move it or how does that work ? Yes, once you become an Orbit committer, you will need to submit a CQ to "add to Orbit". There is a special option in the Foundation Portal "contribution form" to do exactly that ... they are "marked" in a special way in the CQ database ... in particular you'd want to "piggy back" on the original CQ that was approved to add it to an Eclipse project. (Since Riena itself "piggy backed" on CQ 3626, you would want to use 3626 as "the original" one to piggy back on). They are typically approved fairly quickly (since the main IP work has been done, and it is primarily a bookkeeping issue of another project using it). And, finally, you ... and e4! :) ... will have to change your builds to use the Orbit version! :) Most minor ... I don't think there are any "rules" about it, but once you are using the version from Orbit, best to "remove" or otherwise make apparent that the version in your current repo is not the actively used one ... I call that "nulling out the HEAD version (and leave only a README file there in its place in HEAD" ... but, that's probably some old CVS terminology, not sure how that's described in Git, if you are using Git. (In reply to comment #6) > (In reply to comment #4) > > > > > For starters do I need a new CQ to move it or how does that work ? > > Yes, once you become an Orbit committer, you will need to submit a CQ to "add > to Orbit". There is a special option in the Foundation Portal "contribution > form" to do exactly that ... they are "marked" in a special way in the CQ > database ... in particular you'd want to "piggy back" on the original CQ that > was approved to add it to an Eclipse project. (Since Riena itself "piggy > backed" on CQ 3626, you would want to use 3626 as "the original" one to piggy > back on). > > They are typically approved fairly quickly (since the main IP work has been > done, and it is primarily a bookkeeping issue of another project using it). Thanks for that. I am lucky that I CQs and piggy backs. (I have done literally all CQs that Riena ever did :-) ). I just wasnt sure if there is anything different in Orbit. > > And, finally, you ... and e4! :) ... will have to change your builds to use the > Orbit version! :) > > Most minor ... I don't think there are any "rules" about it, but once you are > using the version from Orbit, best to "remove" or otherwise make apparent that > the version in your current repo is not the actively used one ... I call that > "nulling out the HEAD version (and leave only a README file there in its place > in HEAD" ... but, that's probably some old CVS terminology, not sure how that's > described in Git, if you are using Git. Talking of Git, when will Orbit move to Git :-) ? Riena has no copy in its repo, but we just take the version from e4 (in the workspace and in the build). So nothing to NULL. The e4 project will have, so I will contact someone there once we are done. Now, that the CVS server is turned off, there is no possibility to check out this bundle anymore. Is there a reason why it was not migrated to git? I am using this URL: http://git.eclipse.org/gitroot/e4/org.eclipse.e4.ui.git (In reply to comment #8) > Now, that the CVS server is turned off, there is no possibility to check out > this bundle anymore. Is there a reason why it was not migrated to git? > > I am using this URL: > http://git.eclipse.org/gitroot/e4/org.eclipse.e4.ui.git It was likely not migrated because the e4 project is no longer using this library. Now would be a good time to add it to orbit, if Riena or others are still using it. Riena is still using it. Unfortunately Orbit is also not migrated - see Bug 349048 unlucky situation (In reply to comment #10) > Riena is still using it. > Unfortunately Orbit is also not migrated - see Bug 349048 > > unlucky situation Orbit is still using CVS but an exception was made for that. Moving it into Orbit CVS is the right answer at the moment. According to Bug 397237 the anonymous CVS access for Orbit is not working. Was the complete CVS history migrated to git? Riena is using a version from the time where org.pushingpixels.trident was required by E4, so in theory it should be somewhere in the history. (In reply to comment #12) > According to Bug 397237 the anonymous CVS access for Orbit is not working. Once a bundle is in orbit there are many anonymous ways to get it. For example each jar can be downloaded from the orbit downloads page, or there is a p2 repository that can be used to provision it into a target platform. Or is the issue at this point just getting access to the current trident bundle so that it can be contributed to orbit? Christian, if you are not interested or able to put this into Orbit, perhaps you could find another volunteer? Or, return to "inbox". Or, close as "won't fix" if no one currently needs it. (In reply to comment #14) > Christian, if you are not interested or able to put this into Orbit, perhaps > you could find another volunteer? Or, return to "inbox". Or, close as "won't > fix" if no one currently needs it. XWT needs it, too. Adding Yves to CC. Maybe, he is willing to issue a CQ for it. Sorry (or actually I dont think that this can be appologized) I am pretty late to this but I promise to improve... I have opened CQ 7246 to add trident to orbit https://dev.eclipse.org/ipzilla/show_bug.cgi?id=7246 org.pushingpixels.trident is now in Orbit CVS with branch v1_2_0 and tag v201305140926 I am currently waiting for the next Orbit build and post the location for this bundle and then I'll close the bug. (In reply to comment #17) > org.pushingpixels.trident is now in Orbit CVS with branch v1_2_0 and tag > v201305140926 > > I am currently waiting for the next Orbit build and post the location for > this bundle and then I'll close the bug. I think you "messed up" the set1 feature.xml file. Not sure how it'd get in this shape, but, in addition to your adding "trident", there were many other changes that don't make sense. Some were changes that "hard coded" the qualifier, such as <plugin id="javax.xml" download-size="0" install-size="0" version="1.3.4.v201005080400" unpack="false"/> Others appear "worse", in that the actual versions changed, such as <plugin id="javax.servlet.jsp" download-size="0" install-size="0" version="2.2.0.v201112011158" unpack="false"/> instead of <plugin id="javax.servlet.jsp" download-size="0" install-size="0" version="1.2.0.qualifier" unpack="false"/> There were maybe 20 or 30 effected, apparently. Any idea what happened? I have restored the feature.xml to what it was previously, then added just your trident change, will tag, update map, and try another build. oh…. my bad…sorry for that. I pressed that update version button to just update MY plugins version but it did all. Seemed to make sense at that time, but it doesnt… sorry for that Also, just noticed, you did not provide an IP xml file under the ip_logs directory. That will be required before we get a "promotable build" ... but, I'll let you fix that part, and in the mean time, have started a rebuild to see if it basically works now. I added the ip_logs file that I missed Next ... the build is failing with this message ... Processing inclusion from feature org.eclipse.pde.build.container.feature: Unable to find plug-in: org.pushingpixels.trident.source_1.2.0.qualifier I looked in your "source-bundle" directory, and its META-INF does not have a MANIFEST.MF file in it. That source-bundle directory also needs any other "bundle" files, such as about.html, build.properties, etc. I'll temporarily "disable" pushing pixels, by commenting out in feature. Feel free to uncomment when you are back at work on this. addressed the missing files and reenabled the plugin in the feature.xml (In reply to comment #24) > addressed the missing files and reenabled the plugin in the feature.xml Did you remember to tag the feature project and update the map file? That's what will "trigger a build". (In reply to comment #25) > (In reply to comment #24) > > addressed the missing files and reenabled the plugin in the feature.xml > > Did you remember to tag the feature project and update the map file? That's > what will "trigger a build". Oh, and of course, you need to tag the project and update its two map entries too. From a quick glance, I didn't see any changes in map files. (From a quick glance, the bundle looked a lot better though :) (In reply to comment #26) > (In reply to comment #25) > > (In reply to comment #24) > > > addressed the missing files and reenabled the plugin in the feature.xml > > > > Did you remember to tag the feature project and update the map file? That's > > what will "trigger a build". > > Oh, and of course, you need to tag the project and update its two map > entries too. From a quick glance, I didn't see any changes in map files. > > (From a quick glance, the bundle looked a lot better though :) hopefully I have done that now. Where can I look at the hudson building ? (In reply to comment #27) > (In reply to comment #26) > > (In reply to comment #25) > > > (In reply to comment #24) > > hopefully I have done that now. Where can I look at the hudson building ? We're special :) ... not on Hudson, but CruiseControl: http://build.eclipse.org:9777/dashboard/tab/builds I think the timer is set to "check if changes" once every hour, so that's the longest it should take to start a new build. If if doesn't happen by then, you can ping me (or .... you can "manually" start one if you get impatient, with a little button on far right). I updated everything I think, but the build doesnt start. I check back later (In reply to comment #29) > I updated everything I think, but the build doesnt start. I check back later So close! Looks like your source bundle id needs ".source" added? (Wouldn't hurt so add "Source" to its human readable name, so it'd say "Trident Source". (In reply to comment #30) > (In reply to comment #29) > > I updated everything I think, but the build doesnt start. I check back later > > So close! Looks like your source bundle id needs ".source" added? (Wouldn't > hurt so add "Source" to its human readable name, so it'd say "Trident > Source". and a reminder, since you are "new", if won't be offended ... even if you make a change only in "source" folder, Once project is tagged, don't forget to update both lines in map file (they needs to "match"). HTH (In reply to comment #31) > (In reply to comment #30) > > (In reply to comment #29) > > > I updated everything I think, but the build doesnt start. I check back later > > > > So close! Looks like your source bundle id needs ".source" added? (Wouldn't > > hurt so add "Source" to its human readable name, so it'd say "Trident > > Source". > > and a reminder, since you are "new", if won't be offended ... even if you > make a change only in "source" folder, Once project is tagged, don't forget > to update both lines in map file (they needs to "match"). > > HTH updated manifest.mf in source-bundle, committed, tagged, updated BOTH lines in map file. wondering whats next :-)
> ... wondering whats next :-)
Guess you saw the "test failure". If you click on the link, and scroll all the way to the bottom, you'll see
Missing pattern: about.html in file: /shared/orbit/projects/orbit-I/workdir/I20130515210940/repository/plugins/org.pushingpixels.trident.source_1.2.0.v201305152020.jar
Guess you know what that means? :)
(In reply to comment #33) > > ... wondering whats next :-) > > Guess you saw the "test failure". If you click on the link, and scroll all > the way to the bottom, you'll see > > Missing pattern: about.html in file: > /shared/orbit/projects/orbit-I/workdir/I20130515210940/repository/plugins/ > org.pushingpixels.trident.source_1.2.0.v201305152020.jar > > Guess you know what that means? :) Actually I didnt see the "test failure" and I dont know what the missing pattern means. Hmmm First where do I see errors ? I checked these URLs http://build.eclipse.org:9777/dashboard/tab/build/detail/orbit-I/20130515210940 http://build.eclipse.org:9777/dashboard/tab/build/download/log/orbit-I/log20130515210940.xml and here http://build.eclipse.org:9777/dashboard/tab/build/detail/orbit-I/20130515210940 I though I had the about.html everywhere ? Now I shifted it (as I saw it in org.apache.el and maybe that helps. Not that error message really "Missing pattern ???" (In reply to comment #34) > (In reply to comment #33) > > > ... wondering whats next :-) > > > > Guess you saw the "test failure". If you click on the link, and scroll all > > the way to the bottom, you'll see > > > > Missing pattern: about.html in file: > > /shared/orbit/projects/orbit-I/workdir/I20130515210940/repository/plugins/ > > org.pushingpixels.trident.source_1.2.0.v201305152020.jar > > > > Guess you know what that means? :) > > Actually I didnt see the "test failure" and I dont know what the missing > pattern means. Hmmm > You do subscribe to orbit-dev list, right? So, that's "first sign" that build failed, and this one mentions specifically "tests failed". http://dev.eclipse.org/mhonarc/lists/orbit-dev/msg03338.html Next, the "committers download page" at http://build.eclipse.org/orbit/committers/ is usually the best place to start looking for any kind of error. So, for this one, see http://build.eclipse.org/orbit/committers/orbit-I/20130515210940/I20130515210940/ and you'll see the big red X next to "Test Results". That's what to click on to see the specific errors, but agree, it is sort of a dump, and the message is not especially meaningful ... but means "missing file" I think your fix will correct it. (In reply to comment #35) > (In reply to comment #34) > > (In reply to comment #33) > > > > ... wondering whats next :-) > > > > > > Guess you saw the "test failure". If you click on the link, and scroll all > > > the way to the bottom, you'll see > > > > > > Missing pattern: about.html in file: > > > /shared/orbit/projects/orbit-I/workdir/I20130515210940/repository/plugins/ > > > org.pushingpixels.trident.source_1.2.0.v201305152020.jar > > > > > > Guess you know what that means? :) > > > > Actually I didnt see the "test failure" and I dont know what the missing > > pattern means. Hmmm > > > > You do subscribe to orbit-dev list, right? So, that's "first sign" that > build failed, and this one mentions specifically "tests failed". > > http://dev.eclipse.org/mhonarc/lists/orbit-dev/msg03338.html > > Next, the "committers download page" at > http://build.eclipse.org/orbit/committers/ > is usually the best place to start looking for any kind of error. > > So, for this one, see > http://build.eclipse.org/orbit/committers/orbit-I/20130515210940/ > I20130515210940/ > > and you'll see the big red X next to "Test Results". > > That's what to click on to see the specific errors, but agree, it is sort of > a dump, and the message is not especially meaningful ... but means "missing > file" > > I think your fix will correct it. I am actually on orbit-dev but totally forgot about it. The log is pretty large. It has like 43 MB. It seemed that we had a green build in between and now its red again, complaining that it doesnt find the trident.source bundle. I am a little lost why that is happening. I thought the source bundle is generated if I provide this structure. I'm lost too, as to what triggered that build at all. Did you change anything. I was assuming the "green build" included your fix. And, couldn't see what cause the next build to start. The last build I think was fired by a map change that I did because I received a message that the build failed. So I moved about.html. However the build was green already and my move and tag and change of the map file made it red again. Or its totally independant of that… The last build references 1.1157 for the map file. So 1.1156 was ok. Maybe I should roll that back ? What I suggest is you check the green build I promoted, http://download.eclipse.org/tools/orbit/downloads/drops/I20130516141321/ and see if that trident bundle is correct ... code and source. (In reply to comment #39) > What I suggest is you check the green build I promoted, > http://download.eclipse.org/tools/orbit/downloads/drops/I20130516141321/ > > and see if that trident bundle is correct ... code and source. I checked and they both look good. So I what I do tomorrow is I revert the status to the tag of that working thing, and create a new tag and put it in the map file. (In reply to comment #40) > (In reply to comment #39) > > What I suggest is you check the green build I promoted, > > http://download.eclipse.org/tools/orbit/downloads/drops/I20130516141321/ > > > > and see if that trident bundle is correct ... code and source. > > I checked and they both look good. So I what I do tomorrow is I revert the > status to the tag of that working thing, and create a new tag and put it in > the map file. Well, please clarify, that tags you are talking about. I'd like to see what was different. Assuming all fixed. verified org.pushingpixels.trident_1.2.0.v201305152020.jar is in Orbit R-build, but still see (only) org.pushingpixels.trident_1.2.0.201106090835.jar in common repo ... hopefully whoever is using that old version can update for release. |