Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 349491

Summary:

possible NPE on shutdown due to event firing

Product:

[Tools] Target Management

Reporter:

David McKnight <dmcknigh>

Component:

RSE

Assignee:

David McKnight <dmcknigh>

Status:

RESOLVED FIXED

QA Contact:

Martin Oberhuber <mober.at+eclipse>

Severity:

normal

Priority:

CC:

xuanchen

Version:

3.2

Flags:

xuanchen: review+

Target Milestone:

3.3.1

Hardware:

OS:

Windows XP

Whiteboard:

Attachments:

Description	Flags
patch to check for active registry	none

Description David McKnight

2011-06-15 15:00:40 EDT

From the RemoteCmdSubSystem events are fired when shells are disconnected.  During a shutdown, it's possible for system registry to be inactive.  If that's the case, then the events should not be fired.

Comment 1 David McKnight

2011-06-15 15:05:47 EDT

Created attachment 198047 [details]
patch to check for active registry

Comment 2 David McKnight

2011-06-15 15:57:13 EDT

Xuan, could you please review this.  The change is pretty trivial and low-risk so I think we only need one reviewer.

Comment 3 Xuan Chen

2011-06-15 17:30:02 EDT

The fix looks good.  Thanks.

Comment 4 David McKnight

2011-06-16 09:51:54 EDT

Thanks for the review, Xuan.  I've committed the change to the HEAD stream.