Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 349457

Summary:

InternalTreeModelViewer.handleTreeExpand() prints "dude" to System.out

Product:

[Eclipse Project] Platform

Reporter:

Mirko Seifert <mirko.seifert>

Component:

Debug

Assignee:

Pawel Piech <pawel.1.piech>

Status:

VERIFIED FIXED

QA Contact:

Severity:

minor

Priority:

CC:

Michael_Rennie, pawel.1.piech

Version:

4.1

Flags:

Michael_Rennie: review+

Target Milestone:

3.7.1

Hardware:

OS:

Windows 7

Whiteboard:

Attachments:

Description	Flags
Fix.	none

Description Mirko Seifert

2011-06-15 11:11:05 EDT

Build Identifier: I20110526-1708

If a tree item does not have data (event.item.getData() == null) the handleTreeExpand() method prints "dude" to System.out.

I think it should either ignore this, write a decent entry to the error log, or print a meaningful message.

Reproducible: Always

Steps to Reproduce:
Either write a custom debugger that create tree item with no data or write a custom JUnit test that calls an instance of InternalTreeModelViewer with the appropriate arguments.

In any case the bug is obvious from the code.

Comment 1 Pawel Piech

2011-06-15 19:03:36 EDT

Wow, this is really embarrassing :-(  More so that it's been there since March.

Comment 2 Pawel Piech

2011-07-20 12:02:02 EDT

Created attachment 200019 [details]
Fix.

Comment 3 Pawel Piech

2011-07-20 12:02:52 EDT

I already committed the fix to head.

Mike could you review+ to take the dude out of 3.7 branch?

Comment 4 Michael Rennie

2011-07-21 11:58:35 EDT

+1 for 3.7.1

Comment 5 Pawel Piech

2011-07-21 12:12:27 EDT

The Dude abides...

Comment 6 Pawel Piech

2011-07-21 12:12:44 EDT

Already reviewed.