| Summary: | Unconvenient usage of Graphiti in RCP development | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | [Modeling] Graphiti | Reporter: | Daniel Santos <daniel.santos> | ||||||
| Component: | Core | Assignee: | Tim Kaiser <tim.kaiser> | ||||||
| Status: | CLOSED FIXED | QA Contact: | |||||||
| Severity: | enhancement | ||||||||
| Priority: | P3 | CC: | michael.wenz, tim.kaiser | ||||||
| Version: | 0.8.0 | Flags: | michael.wenz:
juno+
|
||||||
| Target Milestone: | 0.9.0 | ||||||||
| Hardware: | All | ||||||||
| OS: | All | ||||||||
| Whiteboard: | Juno M1 theme_round_offs | ||||||||
| Attachments: |
|
||||||||
|
Description
Daniel Santos
IDE dependencies should be removed or seperated. Hi, is a dependency to org.eclipse.ui.workbench tolerable for your use case? Best, Tim That is fine with me. We only found three classes which need to be loaded from org.eclipse.ui.ide. One of them (WorkspaceModifyOperation) could be eliminated. The other two (ResourceTransfer, IFileEditorInput) can be loaded dynamically if there. The dependency to org.eclipse.ui.ide is marked optional now. Created attachment 199127 [details]
mylyn/context/zip
Marked as part of Juno Created attachment 200434 [details]
Fix for 0.7.0 version
Hi Daniel, thanks for the fix. When reviewing your patch i see a lot of differences introduced by new formatting of comments (line breaks). Could you add a patch without formatting comments differently? This would highly improve readability. Best, Tim Bookkeeping: Set target release Part of Graphiti 0.9.0 (Eclipse Juno) |