Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 349435

Summary: Namespace editing dialog doesn't parent the dialog shell correctly
Product: [WebTools] WTP Source Editing Reporter: Remy Suen <remy.suen>
Component: wst.xmlAssignee: Nick Sandonato <nsand.dev>
Status: RESOLVED FIXED QA Contact: Nitin Dahyabhai <thatnitind>
Severity: normal    
Priority: P3 CC: nsand.dev
Version: 3.3   
Target Milestone: 3.3.1   
Hardware: PC   
OS: Windows XP   
Whiteboard:

Description Remy Suen CLA 2011-06-15 09:36:40 EDT
1. Open the 'XPath' view.
2. Ctrl+F10 > Edit Namespace Prefixes
3. If you click the 'Add...' button and then hit ESC, the focus is on the workbench window instead of the dialog window.

CommonEditNamespacesDialog's invokeDialog(*) and performNew() methods are bad. I suggest parenting off your own shell or getting a modal shell provider from IWorkbench's getModalDialogShellProvider() method.
Comment 1 Nick Sandonato CLA 2011-06-15 11:12:10 EDT
Thanks, Remy. Fixed it so the original dialog's shell is used for both invokeDialog() and performNew().