Bugzilla – Full Text Bug Listing
| Summary: | [server][git] Wrong cloneLocation in git log toRef | ||
|---|---|---|---|
| Product: | [ECD] Orion | Reporter: | Piotr Janik <janikpiotrek> |
| Component: | Client | Assignee: | Szymon Brandys <Szymon.Brandys> |
| Status: | RESOLVED FIXED | QA Contact: | |
| Severity: | normal | ||
| Priority: | P3 | CC: | simon_kaegi, Szymon.Brandys, tomasz.zarna |
| Version: | 0.2 | Flags: | tomasz.zarna:
review+
simon_kaegi: review+ |
| Target Milestone: | 0.2 | ||
| Hardware: | PC | ||
| OS: | All | ||
| Whiteboard: | |||
Fix: https://github.com/pjanik/orion.server/tree/bug349428 I wrote all this code and have the rights to contribute it to Eclipse under the eclipse.org web site terms of use. The fix looks good, the CloneLocation should point to the root. The correct CloneLocation is important. This is the case. 1) Create a clone of org.eclipse.orion.client in Orion 2) Open Git Log for a subfolder e.g. bundles/org.eclipse.orion.client.core You will see "Git Log for local branch master on" and no branch name When the fix is applied you'll see "Git Log for local branch master on org.eclipse.orion.client". Looks good, safe enough and worth doing. If anything the path math is simpler. Pushed. The final fix is different from the Piotrek's one. The fix is here http://git.eclipse.org/c/e4/org.eclipse.orion.server.git/commit/?id=30c54dee0e70ff60a24d63b86972a01f60d06245 It is different that Piotrek's one as stated in comment 5. |
example: repository: /file/f GET /gitapi/commit/master/file/f/subfolder/?page=1 toRef structure: "toRef": { "CloneLocation": "/gitapi/clone/file/f/subfolder/", "CommitLocation": "/gitapi/commit/master/file/f/subfolder/", "Current": true, "HeadLocation": "/gitapi/commit/HEAD/file/f/subfolder/", "Location": "/gitapi/branch/master/file/f/subfolder/", "Name": "master", "RemoteLocation": "/gitapi/remote/origin/master/file/f/subfolder/", "Type": "Branch" } cloneLocation is wrong, should be: "/gitapi/clone/file/f/".