Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 349374

Summary:	[server][user] NPE in FormAuthHelper
Product:	[ECD] Orion	Reporter:	John Arthorne <john.arthorne>
Component:	Server	Assignee:	Malgorzata Janczarska <malgorzata.tomczyk>
Status:	RESOLVED FIXED	QA Contact:
Severity:	normal
Priority:	P3	CC:	malgorzata.tomczyk, Szymon.Brandys
Version:	0.2	Keywords:	investigate
Target Milestone:	0.3
Hardware:	PC
OS:	Windows 7
Whiteboard:

Description John Arthorne

2011-06-14 16:49:33 EDT

HEAD as of 20110614

I am seeing several NPE's in my log like the following. I'm not sure what caused it or what effect it might have:

java.lang.NullPointerException: null
	at org.eclipse.orion.server.authentication.form.core.FormAuthHelper.canAddUsers(FormAuthHelper.java:162) ~[na:na]
	at org.eclipse.orion.server.authentication.formopenid.servlets.LoginFormServlet.replaceNewAccount(LoginFormServlet.java:341) ~[na:na]
	at org.eclipse.orion.server.authentication.formopenid.servlets.LoginFormServlet.loadJSResponse(LoginFormServlet.java:205) ~[na:na]
	at org.eclipse.orion.server.authentication.formopenid.servlets.LoginFormServlet.writeJavaScriptResponse(LoginFormServlet.java:176) ~[na:na]
	at org.eclipse.orion.server.authentication.formopenid.servlets.LoginFormServlet.service(LoginFormServlet.java:158) ~[na:na]

Comment 1 Malgorzata Janczarska

2011-09-29 05:34:33 EDT

User admin is added to FormAuthHelper as a service. Probably in this case login dialog was loaded before UserAdmin was bound. But when we switched from multiple UserAdmins to a single UserAdmin I added a dependency between those bundles, so I suppose user admin would be bind as soon as bundle with FormAuthHelper is loaded. Just in case to avoid NPE I added checking. If we don't have reference to user admin we don't allow to create users. But this is only theoretical, should never happen.