Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 349354

Summary: Need to call gdk_cairo_reset_clip when resetting clipping
Product: [Eclipse Project] Platform Reporter: Bogdan Gheorghe <gheorghe>
Component: SWTAssignee: Bogdan Gheorghe <gheorghe>
Status: RESOLVED FIXED QA Contact:
Severity: normal    
Priority: P3 CC: leachbj, mario.curcija, pwebster, remy.suen, Silenio_Quarti
Version: 3.7Flags: Silenio_Quarti: review+
Target Milestone: 3.7.1   
Hardware: PC   
OS: Linux-GTK   
See Also: https://bugs.eclipse.org/bugs/show_bug.cgi?id=333965
Whiteboard:
Bug Depends on:    
Bug Blocks: 333965    
Attachments:
Description Flags
Patch none

Description Bogdan Gheorghe CLA 2011-06-14 14:23:43 EDT 
GTK 2.18 and greater makes use of nonnative windows. We need to make use of gdk_cairo_reset_clip() instead of directly calling cairo_reset_clip() since calling the latter will "unset the clip region inherited from the drawable (i.e. the window clip region), and thus let you e.g. draw outside your window."
Comment 1 Remy Suen CLA 2011-06-20 11:09:23 EDT 
This showed up while I was searching for Windows bugs. :)
Comment 2 Bogdan Gheorghe CLA 2011-08-05 15:51:07 EDT 
Created attachment 201020 [details]
Patch

Patch for review
Comment 3 Bogdan Gheorghe CLA 2011-08-05 15:59:54 EDT 
Fixed in HEAD and in 3.7 maintenance > 20110805.
Comment 4 Silenio Quarti CLA 2011-10-24 22:28:33 EDT 
*** Bug 344909 has been marked as a duplicate of this bug. ***