Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 349330

Summary: unnecessary 'duplicate generator' validation when name is ""
Product: [WebTools] Dali JPA Tools Reporter: Karen Butzke <karenfbutzke>
Component: JPAAssignee: Nan Li <nan.n.li>
Status: VERIFIED FIXED QA Contact:
Severity: minor    
Priority: P3 CC: jolene.moffitt, neil.hauge
Version: 3.0Flags: neil.hauge: review+
Target Milestone: 3.1 M1   
Hardware: PC   
OS: Windows XP   
Whiteboard:
Attachments:
Description Flags
Proposed Patch neil.hauge: iplog+

Description Karen Butzke CLA 2011-06-14 10:54:06 EDT
Create an EclipseLink JPA project and add this entity. Notice there are 6 validation errors. 2 for the converters being unnamed, 2 for the generators being unnamed and 2 for duplicate generators. We do not need the duplicate generators error if the name is "". This should work the same way converters do. The same issues exists for queries.

@Entity
@TableGenerator(name="")
@SequenceGenerator(name="")
@Converter(name="", converterClass=MyConverter.class)
@TypeConverter(name="")
public class Foo {

	@Id
	private int id;
  
}
Comment 1 Nan Li CLA 2011-06-15 16:01:16 EDT
Created attachment 198049 [details]
Proposed Patch
Comment 2 Neil Hauge CLA 2011-07-01 16:25:33 EDT
Moving JPA specific bugs to new JPA component in bugzilla.
Comment 3 Neil Hauge CLA 2011-07-05 17:07:33 EDT
Patch applied to head.
Comment 4 Jolene Moffitt CLA 2011-08-31 12:07:59 EDT
Verified in Build I-3.4.0-20110826171354 

Verified the 2 Duplicate Generator errors do not appear in the problems pane.  See the link to view test steps for verification. 
http://wiki.eclipse.org/Dali_3.1_M1