Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 349317

Summary: [Unit Test Failure] Bug345730Test.bug345730Test
Product: z_Archived Reporter: Gregoire Dupe <gdupe>
Component: EMF-FacetAssignee: Gregoire Dupe <gdupe>
Status: CLOSED FIXED QA Contact:
Severity: normal    
Priority: P1 CC: emft.facet-inbox
Version: unspecifiedFlags: gdupe: juno+
Target Milestone: ---   
Hardware: PC   
OS: Linux   
Whiteboard:
Attachments:
Description Flags
Patch for Bug 349317 gdupe: iplog+

Description Gregoire Dupe CLA 2011-06-14 09:57:52 EDT 
The unit test Bug345730Test.bug345730Test fails on the build server.

Testcase: bug345730Test took 0.983 sec
	Caused an ERROR

java.lang.AssertionError: 
	at org.eclipse.emf.facet.widgets.nattable.tests.swtbot.Bug345730Test.bug345730Test(Bug345730Test.java:208)
	at org.eclipse.swtbot.eclipse.junit4.headless.EclipseTestRunner.run(EclipseTestRunner.java:350)
	at org.eclipse.swtbot.eclipse.junit4.headless.EclipseTestRunner.run(EclipseTestRunner.java:208)
	at org.eclipse.swtbot.eclipse.junit4.headless.UITestApplication.runTests(UITestApplication.java:116)
	at org.eclipse.ui.internal.testing.WorkbenchTestable$1.run(WorkbenchTestable.java:71)
	at java.lang.Thread.run(Thread.java:595)

Build timed out. Aborting
Comment 1 Nicolas Guyomar CLA 2011-06-14 10:12:45 EDT 
Created attachment 197953 [details]
Patch for Bug 349317

Hi,

Please find attached a fix on the non regression test for Bug 345730.
The EMF Facet Table dirty mode behavior has been modified in Bug 344921.

Expected behavior is that when opened from a model editor, the EMF Facet Table Editor should be dirty, but the model editor should not.

(a) I, Nicolas Guyomar, wrote 100% of the code I've provided.
(b) I have the right to contribute the code to Eclipse.
(c) I contribute the content under the EPL.
(d) This contribution contains no Cryptography features.

Regards,
Nicolas Guyomar
Comment 2 Gregoire Dupe CLA 2011-06-14 11:09:33 EDT 
Comment on attachment 197953 [details]
Patch for Bug 349317

Here is a contribution from one employee of Mia-Software, targeting future
Indigo release. The company has signed a Member Commiter Agreement. The
contribution does not need a CQ (see bug 322327).

I've committed this contribution.

Committed revision 722.
Comment 3 Gregoire Dupe CLA 2011-06-14 11:09:54 EDT 
This bug can be marked as fixed.
Comment 4 Gregoire Dupe CLA 2011-12-26 07:43:35 EST 
Can be closed.