Bugzilla – Full Text Bug Listing
| Summary: | [DataBinding] WorkbenchProperties.SelectionServiceListener ignores arguments given to selectionChanged() when delegating to NativePropertyListener.fireChanged() | ||||||
|---|---|---|---|---|---|---|---|
| Product: | [Eclipse Project] Platform | Reporter: | thammers <jawr> | ||||
| Component: | UI | Assignee: | Dani Megert <daniel_megert> | ||||
| Status: | VERIFIED FIXED | QA Contact: | Matthew Hall <qualidafial> | ||||
| Severity: | normal | ||||||
| Priority: | P3 | CC: | bokowski, daniel_megert, mallo.ovidio, ob1.eclipse, pwebster, qualidafial, remy.suen | ||||
| Version: | 3.7 | ||||||
| Target Milestone: | 3.8 M3 | ||||||
| Hardware: | All | ||||||
| OS: | All | ||||||
| Whiteboard: | |||||||
| Bug Depends on: | |||||||
| Bug Blocks: | 357568, 358920, 362709 | ||||||
| Attachments: |
|
||||||
Boris? PW (In reply to comment #0) > Due to this fact the provided WorkbenchProperties are unusable. That's too bad, sorry about that! Unfortunately, this bug report is coming in too late for the 3.7 release which is essentially done now. Marking for 3.7.1. Created attachment 202119 [details]
Fix
Who is maintaining WorkbenchProperties? (In reply to comment #4) > Who is maintaining WorkbenchProperties? Since it's data binding, I have you on the list ;-). Why? I helped review the initial submission for correctness but didn't know I would be maintaining it. I'm fine with that, but first I need to know where it is in CVS. Also, what are you doing up so late? ;-) (In reply to comment #6) > I helped review the initial submission for correctness but didn't know I would > be maintaining it. If that's not the case you should speak to Paul or Eric. > I'm fine with that, but first I need to know where it is in > CVS. Platform UI code is no longer in CVS. It has been moved to Git, see http://wiki.eclipse.org/Platform_UI/Git for details. > Also, what are you doing up so late? ;-) I'm sitting in Zurich :-) Regarding this bug: I plan to put it into 3.7.2. If you could quickly review it that would be great. (In reply to comment #7) > Platform UI code is no longer in CVS. It has been moved to Git, see > http://wiki.eclipse.org/Platform_UI/Git for details. To borrow an Adam Sandler quote: "Something that should have been brought to my attention YESTERDAY!" I've been on hiatus for a while and didn't know that DataBinding had been migrated to Git. Which means the patches I committed yesterday to CVS need to be committed to Git. Hooray. (In reply to comment #8) > (In reply to comment #7) > > Platform UI code is no longer in CVS. It has been moved to Git, see > > http://wiki.eclipse.org/Platform_UI/Git for details. > > To borrow an Adam Sandler quote: "Something that should have been brought to my > attention YESTERDAY!" It has been announced on the platform-ui developer mailing list several times in Juliy, e.g. http://dev.eclipse.org/mhonarc/lists/platform-ui-dev/msg04971.html. Due to an extended delay getting approval paperwork from my new employer to remain an Eclipse committer, EF removed me from those mailing lists. Unfortunately, I was not reinstated to them once the paperwork went through. I'm actually still a little torqued about how that was handled from the EF side.</rant> I've looked around on the committer portal but have not found a way to sign up for the mailing lists. > I've looked around on the committer portal but have not found a way to sign up > for the mailing lists. Just register here: https://dev.eclipse.org/mailman/listinfo/platform-ui-dev On its face, the code looks correct. Do we have a use case to verify it actually fixes the problem? R3_development commit 39bea189cb93b09fa4a5aab4a7189a586d22b503 I cherry picked it in my R4_dev workspace but so far I get an error when trying to push. Grrr! I'll clone this bug for 3.7.2 once I've sorted out the push issue. > I cherry picked it in my R4_dev workspace but so far I get an error when trying > to push. Grrr! Restart fixed the issue. R4_development commit: 07354e7cef1b36f0f71f9fd1795506ed802f5a67 > I'll clone this bug for 3.7.2 once I've sorted out the push issue. See bug 358920. Verified in 3.8-I20111025-1800 and 4.2-I20111018-2000. (In reply to comment #13) > R3_development commit 39bea189cb93b09fa4a5aab4a7189a586d22b503 The correct change id is: 5588a2feb355998573c4f56bd103ad4d1c5c3eb4 |
Build Identifier: I20110603-0909 The inner class SelectionServiceListener always calls its inherited method fireChanged() with arguments (null, null) ignoring the part and selection passed to selectionChanged(). The super class NativePropertyListener creates a new SimplePropertyEvent in fireChanged() and passes through the null values. This results in an IllegalArgumentException ("null source") in the constructor of SimplePropertyEvent/EventObject. Due to this fact the provided WorkbenchProperties are unusable. Reproducible: Always