Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 349227

Summary: [Client]Compare editor: Remove border style for diff blocks
Product: [ECD] Orion Reporter: libing wang <libingw>
Component: ClientAssignee: libing wang <libingw>
Status: CLOSED FIXED QA Contact:
Severity: normal    
Priority: P2 CC: bokowski, eclipse.felipe, Silenio_Quarti, simon_kaegi, susan
Version: 0.2   
Target Milestone: 0.2   
Hardware: PC   
OS: Windows 7   
Whiteboard:

Description libing wang CLA 2011-06-13 16:00:01 EDT 
Currently we are using BorderStyle to render the diff blocks in side by side compare editor.This affects the line height in the Orion standard editor.
We found some issues :
1.Clicking on inside a diff block does not put the text input cursor properly
2.Range selecting text is flashing inside a diff block.
3.Ruler does not align well if there are a few numbers of diff blocks
The reason of all above is because the line height on a bordered line  is slightly bigger than a normal line.
A temporary solution in 0.2 is to remove the border and use slightly darker background color for the diff blocks.
For the current diff , we will use darker background color than the normal diff block.
For the conflicting block , we will use light red color.
Comment 1 Simon Kaegi CLA 2011-06-13 17:03:59 EDT 
+1 for doing something about this in RC2
Comment 2 libing wang CLA 2011-06-14 11:30:05 EDT 
fixed with 789bbd90a7e22a95d3bb6e13c98b9ce1fee7d654.
Code reviewed by Felipe and Silenio.