Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 349189

Summary: [metatype] Evaluate impact of resolved CPEG bugs on Metatype impl.
Product: [Eclipse Project] Equinox Reporter: John Ross <jwross>
Component: CompendiumAssignee: John Ross <jwross>
Status: RESOLVED FIXED QA Contact:
Severity: normal    
Priority: P3 CC: tjwatson
Version: 3.7   
Target Milestone: Juno   
Hardware: PC   
OS: Windows XP   
Whiteboard:
Bug Depends on:    
Bug Blocks: 364459    

Description John Ross CLA 2011-06-13 09:27:08 EDT 
Need to make sure the Metatype impl conforms to the outcome of the following resolved CPEG bugs or dispute the resolutions.

https://www.osgi.org/members/bugzilla/show_bug.cgi?id=1843

https://www.osgi.org/members/bugzilla/show_bug.cgi?id=1979

https://www.osgi.org/members/bugzilla/show_bug.cgi?id=1974

https://www.osgi.org/members/bugzilla/show_bug.cgi?id=1975

I'm pretty sure it does, but want to be sure the resolutions are reviewed.
Comment 1 John Ross CLA 2011-06-13 09:36:53 EDT 
If I recall correctly, the current impl will simply return null for an image icon if the specified size does not match exactly. We will probably need an algorithm for determining the icon with the closest matching size and return that instead of null.
Comment 4 John Ross CLA 2011-11-18 17:34:56 EST 
(In reply to comment #2)
> > https://www.osgi.org/members/bugzilla/show_bug.cgi?id=1843
> > https://www.osgi.org/members/bugzilla/show_bug.cgi?id=1979
> > https://www.osgi.org/members/bugzilla/show_bug.cgi?id=1974
> > https://www.osgi.org/members/bugzilla/show_bug.cgi?id=1975
> https://www.osgi.org/members/bugzilla/show_bug.cgi?id=2182
> https://www.osgi.org/members/bugzilla/show_bug.cgi?id=2196

Everything looks okay except for 1975. Support for multiple icons in the schema needs to be added as well as an algorithm for finding an icon whose size matches as closely as possible the requested size.