Bug 349119

Description Andreas Muelder 2011-06-11 08:11:38 EDT

Build Identifier: 

When I use a CanonicalEditPolicy or a ConnectionCanonicalEditPolicy, Notes and Text elements are deleted, because the default behaviour is to delete all views where the semantic model element is null.

I think it would be better to check for these view types in the #shouldDeleteView() method, instead of simply returning true as the default.

Possible default implementation could be someting like this:

protected boolean shouldDeleteView(View view) {
  if (ViewType.NOTE.equals(view.getType())
      | ViewType.NOTEATTACHMENT.equals(view.getType())
       || ViewType.TEXT.equals(view.getType())) {
    return false;
   }
   return true;
}


Reproducible: Always