Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 349033

Summary:	Software Repository Reports: bundle name and provider names check and l10n bundle.properties
Product:	Community	Reporter:	Andrew Johnson <andrew_johnson>
Component:	Cross-Project	Assignee:	Cross-Project issues <cross-project.inbox>
Status:	RESOLVED WORKSFORME	QA Contact:
Severity:	normal
Priority:	P3	CC:	david_williams
Version:	unspecified
Target Milestone:	---
Hardware:	All
OS:	All
Whiteboard:
Bug Depends on:
Bug Blocks:	348838

Description Andrew Johnson

2011-06-10 10:00:36 EDT

Bug 348838 shows a warning about a missing bundle and missing provider names. The names are actually present via OSGi/l10n/bundle.properties and do appear in the product p2 bundle list from Help > About.

Is this a problem with the checking code?

Comment 1 David Williams

2011-06-10 11:36:51 EDT

There certainly might be a bug in the name checking (I've not checked it too closely) but another possibility is that the o.e.mat bundles,
mentioned in Bug 348838, are being "published" with a version of publisher prior to 3.6 RC1? See bug 309566 for discussion/fix for when the publisher used to not work for the (spec'd) OSGi localization. 

And, as described in bug 309566 the code that displays things in About box is a different code path, so it was working after things installed, but if you look at "properties" before installed ... you'll probably see the mis-published data. If so, the "fix" might be as simply as moving to a more recent "builder"?

Comment 2 David Williams

2011-06-10 23:36:34 EDT

I did confirm, by hand, a bundle from WTP, org.eclipse.wst.jsdt.debug.core, that uses /OSGI-INF/l10n/bundle.properties and the report correctly displays its name as "JavaScript Debug Core". So, pretty sure the discrepancy you are seeing on o.e.mat bundle is related to using an old version of builder/publisher. Let us know and/or reopen this bug, if you find out differently.

I will admit, though, that I tried to find a "bundle" to display its name in normal installer, for normal, common repository, and I could not. So, the "bad" metadata in your mat repo's metadata would probably never be noticed by any user. I'd recommend you not fix it "just for the report", but I think it will be fixed automatically if/when you update the version of your builder/publisher so it includes the 3.6 RC1 fix ... and, really, shouldn't your builder/publisher be more current? :)

I should mention that in theory, a p2 repository _can_ display bundle names ... they are just IUs after all :) ... we do in Orbit's repository, for example. See http://download.eclipse.org/tools/orbit/downloads/drops/R20110523182458/repository/
So it is true that the repositories metadata is not correct, until the localization is correctly published ... even though users may not currently see it.

Also, from my experience, I'd guess the fast majority of the "problems" the report makes obvious are not from the version of the builder/publisher used, but the more mundane problems like forgetting to "export" the bundle.properties file or not having matching variables names, etc.

Thanks for bring this issue to everyone's attention.