Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 349022

Summary:	NPE when download fails
Product:	[Technology] MPC	Reporter:	Steffen Pingel <steffen.pingel>
Component:	Install	Assignee:	Project Inbox <mpc.install-inbox>
Status:	RESOLVED FIXED	QA Contact:
Severity:	normal
Priority:	P3
Version:	unspecified
Target Milestone:	1.1.1
Hardware:	PC
OS:	Linux
Whiteboard:

Description Steffen Pingel

2011-06-10 09:16:54 EDT

Found the exception below in the log (not sure what caused it):

eclipse.buildId=I20110603-0909
java.version=1.6.0_24
java.vendor=Sun Microsystems Inc.
BootLoader constants: OS=linux, ARCH=x86_64, WS=gtk, NL=en_CA
Framework arguments:  -product org.eclipse.epp.package.java.product
Command-line arguments:  -os linux -ws gtk -arch x86_64 -product org.eclipse.epp.package.java.product

Error
Fri Jun 10 15:03:35 CEST 2011
Unexpected exception: Multiple errors occurred

org.eclipse.core.runtime.CoreException: Multiple errors occurred
	at org.eclipse.epp.internal.mpc.ui.util.ConcurrentTaskManager.waitUntilFinished(ConcurrentTaskManager.java:118)
	at org.eclipse.epp.internal.mpc.ui.catalog.MarketplaceDiscoveryStrategy.handleSearchResult(MarketplaceDiscoveryStrategy.java:260)
	at org.eclipse.epp.internal.mpc.ui.catalog.MarketplaceDiscoveryStrategy.performQuery(MarketplaceDiscoveryStrategy.java:420)
	at org.eclipse.epp.internal.mpc.ui.catalog.MarketplaceCatalog$6.run(MarketplaceCatalog.java:120)
	at org.eclipse.epp.internal.mpc.ui.catalog.MarketplaceCatalog.performDiscovery(MarketplaceCatalog.java:322)
	at org.eclipse.epp.internal.mpc.ui.catalog.MarketplaceCatalog.performQuery(MarketplaceCatalog.java:118)
	at org.eclipse.epp.internal.mpc.ui.wizards.SelectionModelStateSerializer.deserialize(SelectionModelStateSerializer.java:82)
	at org.eclipse.epp.internal.mpc.ui.wizards.MarketplaceWizard$2.run(MarketplaceWizard.java:147)
	at org.eclipse.jface.operation.ModalContext$ModalContextThread.run(ModalContext.java:121)
Contains: 
java.lang.NullPointerException
	at org.eclipse.epp.internal.mpc.ui.catalog.AbstractResourceRunnable.run(AbstractResourceRunnable.java:67)
	at org.eclipse.epp.internal.mpc.ui.catalog.AbstractResourceRunnable.call(AbstractResourceRunnable.java:50)
	at java.util.concurrent.FutureTask$Sync.innerRun(FutureTask.java:303)
	at java.util.concurrent.FutureTask.run(FutureTask.java:138)
	at java.util.concurrent.ThreadPoolExecutor$Worker.runTask(ThreadPoolExecutor.java:886)
	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:908)
	at java.lang.Thread.run(Thread.java:662)
Contains: 
java.lang.NullPointerException
	at org.eclipse.epp.internal.mpc.ui.catalog.AbstractResourceRunnable.run(AbstractResourceRunnable.java:67)
	at org.eclipse.epp.internal.mpc.ui.catalog.AbstractResourceRunnable.call(AbstractResourceRunnable.java:50)
	at java.util.concurrent.FutureTask$Sync.innerRun(FutureTask.java:303)
	at java.util.concurrent.FutureTask.run(FutureTask.java:138)
	at java.util.concurrent.ThreadPoolExecutor$Worker.runTask(ThreadPoolExecutor.java:886)
	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:908)
	at java.lang.Thread.run(Thread.java:662)

Comment 1 Benjamin Muskalla

2011-07-20 23:01:27 EDT

Can happen if we use a broken image URI or some IO craziness happens. Added check that we only close the stream if we got one. Pushed as 65fa6b9a1b248255d03988b8ff3171bc5ad38ee0.