Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 348946

Summary: [RDT] header file has been treated as source file to parse by remote indexer
Product: [Tools] PTP Reporter: John Liu <jwsliu>
Component: RDTAssignee: Project Inbox <ptp-inbox>
Status: CLOSED WONTFIX QA Contact:
Severity: normal    
Priority: P3 CC: g.watson, recoskie
Version: unspecified   
Target Milestone: ---   
Hardware: PC   
OS: Windows XP   
Whiteboard:
Attachments:
Description Flags
api update patch
none
A bit updated patch
g.watson: iplog+
a fix patch
none
Updated fix patch none

Description John Liu CLA 2011-06-09 15:15:51 EDT 
As investigating another bugzilla, https://bugs.eclipse.org/bugs/show_bug.cgi?id=346349, I found out that the remote indexer has been treat header files as source files to parse. This is because the variable of fValidSourceUnitNames(a list of source files extensions) in the standaloneIndexer class never gets populated, so when StandaloneIndexerInputAdapter ask if a file is a source unit, it always return true, then it will be parsed as a source unit.

This may not have a big impact in the parse result, but after we fix this bug, we have to run a thorough indexer test to make sure everything still works OK.
Comment 1 John Liu CLA 2011-06-09 16:32:40 EDT 
Created attachment 197736 [details]
api update patch

Add the api changes of the fix first, hoping I can include the api update into Indigo.
This fix doesn't interact with any existing functions, so it has no impact to anything.
Comment 2 Greg Watson CLA 2011-06-09 16:36:21 EDT 
RC4a was the final build. No further builds are planned at this stage.
Comment 3 John Liu CLA 2011-06-09 16:42:06 EDT 
Created attachment 197738 [details]
A bit updated patch
Comment 4 John Liu CLA 2011-06-09 17:05:34 EDT 
(In reply to comment #2)
> RC4a was the final build. No further builds are planned at this stage.

Hi, Greg:

We understand it is impossible to add the entire fix into Indigo at this late, but we are hoping we can update the api first in Indigo, then later on when we add a real fix, we won't break the api changing rule.

This fix is juts like a place holder and doesn't interact with any existing functions, so it has no impact to any of current functions.

Is it possible to have another build to include this patch in?
Comment 5 Greg Watson CLA 2011-06-09 18:08:48 EDT 
Do you have API tooling enabled? I don't see any version number changes in the patch.

Unfortunately it is not possible to update the PTP build as this late stage as the Indigo builds have been disabled pending release of the RC4 milestone tomorrow. 

Even if I do another PTP build, and a rebuild of Indigo is requested before GA, they will still probably reject the update if any version numbers have changed.
Comment 6 John Liu CLA 2011-06-10 09:27:38 EDT 
(In reply to comment #5)
> Do you have API tooling enabled? I don't see any version number changes in the
> patch.
> Unfortunately it is not possible to update the PTP build as this late stage as
> the Indigo builds have been disabled pending release of the RC4 milestone
> tomorrow. 
> Even if I do another PTP build, and a rebuild of Indigo is requested before GA,
> they will still probably reject the update if any version numbers have changed.

Ah I see, then I guess we will have to wait for a fix pack to add it.

I have API tooling enabled and added a since tag to the new api function, getFValidSourceUnitNames, as the plugin version was already updated, so I didn't change it. Should I update something else?
Comment 7 Greg Watson CLA 2011-06-13 10:10:25 EDT 
The package is internal, so this is not an API change. I've committed this patch, so if there's a rebuild of Indigo it may get in.
Comment 8 Chris Recoskie CLA 2011-06-13 10:20:49 EDT 
John is a committer... shouldn't this be iplog- ?
Comment 9 Greg Watson CLA 2011-06-13 10:48:39 EDT 
I don't think it needs any iplog in that case.
Comment 10 John Liu CLA 2011-06-14 15:10:46 EDT 
Created attachment 197970 [details]
a fix patch

add a fix patch on top of the previous api update patch, will wait until Indigo is completed and then commit it into a fix pack.
Comment 11 John Liu CLA 2011-06-14 15:22:48 EDT 
Created attachment 197972 [details]
Updated fix patch
Comment 12 Greg Watson CLA 2014-05-29 15:23:12 EDT 
It doesn't look like this was ever applied.