Bug 348914

Description Yann Tanguy 2011-06-09 11:10:23 EDT

Two click Edge creation - click to select source - click to select target.


It’s a permanent enhancement, the change was made in r4587 (org.eclipse.papyrus.diagram.common.service.AspectUnspecifiedTypeConnectionTool::handleButtonUp() method)

       /**
       * @see org.eclipse.gef.tools.AbstractTool#handleButtonUp(int)
       */
       protected boolean handleButtonUp(int button) {
             setCtrlKeyDown(getCurrentInput().isControlKeyDown());

             if(isInState(STATE_CONNECTION_STARTED)) {
                    setState(STATE_CONNECTION_WAITING_END);
                    return false;
             } else if(isInState(STATE_CONNECTION_WAITING_END)) {
                    handleCreateConnection();
             }

             setState(STATE_TERMINAL);

             if(isInState(STATE_TERMINAL | STATE_INVALID)) {
                    handleFinished();
             }

             return true;
       }

instead of 

       /**
       * @see org.eclipse.gef.tools.AbstractTool#handleButtonUp(int)
       */
       protected boolean handleButtonUp(int button) {
             setCtrlKeyDown(getCurrentInput().isControlKeyDown());

             if (isInState(STATE_CONNECTION_STARTED))
                    handleCreateConnection();
             setState(STATE_TERMINAL);

             if (isInState(STATE_TERMINAL | STATE_INVALID)) {
                    handleFinished();
             }

             return true;
       }

Regards,

Yann

De : mdt-papyrus.dev-bounces@eclipse.org [mailto:mdt-papyrus.dev-bounces@eclipse.org] De la part de 
Objet : [mdt-papyrus.dev] Edge creation

Hi,
            I am currently working on Papyrus and I have just discovered that the edge creation method has changed. Before the edge has to be dragged from one point to another whereas now you have to click on the starting point and on the ending to create it. I would like to know if it’s a permanent enhancement or if it’s just temporary. In fact, it impacts a framework I’m working on. Can someone please confirm that it’s permanent?