Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 348912

Summary:	[server]git : GET CloneLocation returns nothing on a linked repo
Product:	[ECD] Orion	Reporter:	libing wang <libingw>
Component:	Client	Assignee:	Tomasz Zarna <tomasz.zarna>
Status:	RESOLVED FIXED	QA Contact:
Severity:	major
Priority:	P3	CC:	bokowski, simon_kaegi, susan, Szymon.Brandys
Version:	0.2	Flags:	Szymon.Brandys: review+
Target Milestone:	0.2
Hardware:	PC
OS:	Windows 7
Whiteboard:

Description libing wang

2011-06-09 11:02:20 EDT

In git status page ,currently I am using GET gitStatusResponse.CloneLocation to obtain clone information and doing further GETs to obtain branch and remote properties.

This works well if my repo is cloned from Orion repo page.
For a linked repo (where I cloned outside of Orino and linked it to a folder) , there is no response on the GET gitStatusResponse.CloneLocation.
I think it is reasonable because linked repo might be temporary solution.
But we have to make it consistent.
If I go to git log page from a linked repo I can still do it . This makes the end user think that the git status page is buggy.

In my opinion , returning the branch and remote info in the gitStatusResponse directly may resolve the issue but it may not be targeted in RC2.

Comment 1 libing wang

2011-06-09 11:07:58 EDT

One more thing to mention , I could see the linked repo in the repo page.
This made me think that this repo is under control by Orion.

Comment 2 Boris Bokowski

2011-06-09 11:14:26 EDT

I would like to know why you need to clone using Orion to be able to get the branch information. Do we keep additional metadata on the Orion side that is not available through JGit?

Comment 3 Simon Kaegi

2011-06-09 11:37:49 EDT

(In reply to comment #2)
> I would like to know why you need to clone using Orion to be able to get the
> branch information. Do we keep additional metadata on the Orion side that is
> not available through JGit?

+1, it would be a real pity if we can't get this info for the linked use-cases to work. I also would like to understand if this is possible and if not for RC1 think it's worth considering for RC2.

Comment 4 libing wang

2011-06-09 11:38:40 EDT

(In reply to comment #2)
> I would like to know why you need to clone using Orion to be able to get the
> branch information. 
When I opened Bug 347849 , I intended to get the branch and remote properties from git status response directly.
From the solution , I am using GET again on statusResponse.CloneLocaltion. But this GET returns nothing when the status page is on a linked repo.

Comment 5 Tomasz Zarna

2011-06-09 11:46:33 EDT

(In reply to comment #4)
> I am using GET again on statusResponse.CloneLocaltion. But
> this GET returns nothing when the status page is on a linked repo.

By 'nothing' you mean '{"Children": []}' ? This is what I get after calling GET on a linked repo CloneLocation. I'm not saying it's a proper response, just making sure we're on the same page.

Comment 6 Tomasz Zarna

2011-06-09 11:55:02 EDT

(In reply to comment #2)
> Do we keep additional metadata on the Orion side that is not
> available through JGit?

No, this should work, but to be honest I didn't pay much attention to linked clones as they supposed to be a short term solution.

Comment 7 Boris Bokowski

2011-06-09 12:11:16 EDT

(In reply to comment #5)
> By 'nothing' you mean '{"Children": []}' ? This is what I get after calling GET
> on a linked repo CloneLocation. I'm not saying it's a proper response, just
> making sure we're on the same page.

Yes, this seems to be the underlying problem as far as I understand.

Comment 8 Boris Bokowski

2011-06-09 12:52:07 EDT

I am seeing the {"Children": []} response on orion.eclipse.org with a newly cloned repository (I used ssh://bbokowski@git.eclipse.org/gitroot/e4/org.eclipse.orion.client.git).

Comment 9 Susan McCourt

2011-06-09 13:01:55 EDT

see also bug 344038 which I really believe is the same bug.
For some time now we have observed git repos which start out working (whether they be links or clones) and then the git log goes blank.

Comment 10 Boris Bokowski

2011-06-09 20:34:14 EDT

(In reply to comment #8)
> I am seeing the {"Children": []} response on orion.eclipse.org with a newly
> cloned repository (I used
> ssh://bbokowski@git.eclipse.org/gitroot/e4/org.eclipse.orion.client.git).

Does the above count as reproducible steps?

Comment 11 Boris Bokowski

2011-06-09 20:36:01 EDT

At least major from my point of view. None of the Git repositories I have on orion.eclipse.org show log information on the git status page. Can you please look into this as quickly as possible? Thanks!

Comment 12 Tomasz Zarna

2011-06-10 06:50:17 EDT

Fixed with http://git.eclipse.org/c/e4/org.eclipse.orion.server.git/commit/?id=0ed853f87fe73a2cacba36120bc3473ce4dc4092.

Comment 13 Tomasz Zarna

2011-06-10 09:01:06 EDT

(In reply to comment #9)
> For some time now we have observed git repos which start out working (whether
> they be links or clones) and then the git log goes blank.

It sounds similar to what Gosia described on bug 347172.