| Summary: | org.eclipse.jgit_0.12.1.jar contribution to /releases/staging | ||||||
|---|---|---|---|---|---|---|---|
| Product: | [Tools] PTP | Reporter: | Markus Knauer <mknauer> | ||||
| Component: | RDT.sync | Assignee: | Project Inbox <ptp-inbox> | ||||
| Status: | RESOLVED FIXED | QA Contact: | |||||
| Severity: | critical | ||||||
| Priority: | P3 | CC: | beth, david_williams, g.watson, matthias.sohn, roland | ||||
| Version: | unspecified | ||||||
| Target Milestone: | --- | ||||||
| Hardware: | PC | ||||||
| OS: | Linux | ||||||
| Whiteboard: | |||||||
| Attachments: |
|
||||||
|
Description
Markus Knauer
Markus, any idea where this would be coming from? None of the plugins in the feature have a specific requirement for 0.12.1. The only place I can see it is in the build script where it is copied into the update site. I can try removing this to see what happens. Re-running build with this removed... (In reply to comment #1) > Markus, any idea where this would be coming from? Not really. Maybe it is pulled in by a feature-include with version number 0.0.0 and got replaced during the build with the version from the target. Created attachment 197699 [details]
JGit dependency problem
I think a change in the org.eclipse.ptp.rdt.sync feature like the attached one in the patch could help. I removed the bundle org.eclipse.jgit from the list of plug-ins and moved it to the list of dependencies.
Of course, that does mean that a user installing this feature must have access to a repository containing org.eclipse.jgit which would not be included in your own repository any more, but this is probably acceptable (and what you want) since everything is available from the Indigo repository anyway. Speaking of this, that is the reason for the checkbox "Contact all update sites during install to find required software" in the install dialog.
I'm running a build right now that has the plugin removed but doesn't have the <requires> entry. Do you think this is ok, or should I restart the build? No need to answer that. The build failed because of unsatisfied imports (jgit). Rebuilding... (In reply to comment #6) > No need to answer that. The build failed because of unsatisfied imports (jgit). Yepp, that is half-expected. Do you have org.eclipse.jgit in your target that you are using for your build? And which kind of build are you using? PDE, Buckminster, Maven, ...? It still failed. I'm using a PDE build. I think I need to have jgit in my target as you suggest. I do this for CDT, RSE and a few other things, so will try adding jgit. Any idea where I can get it from? The latest in downloads/jgit/maven/org/eclipse/jgit/org.eclipse.jgit seems to be 0.9.3. (In reply to comment #9) > Any idea where I can get it from? The latest in > downloads/jgit/maven/org/eclipse/jgit/org.eclipse.jgit seems to be 0.9.3. org.eclipse.jgit_1.0.0.201106090707-r.jar from releases/staging would be a candidate (http://download.eclipse.org/releases/staging/aggregate/plugins/org.eclipse.jgit_1.0.0.201106090707-r.jar). The longer answer could be: Many projects are building against a target that is a sub-set of /releases/staging; if they don't use this as an input, it is expected that it they use something that is compatible with what is there. Sometimes it helps to look in the .b3aggrcon files, in that case it is the "egit" contribution file /org.eclipse.indigo.build/egit.b3aggrcon. (Good luck for the rebuild, I hope it finishes successful now!) Build is finished and installed in update site. Looks good so far. We'll need to kick off another indigo aggregation I guess. I checked your repository at /tools/ptp/updates/indigo/, especially content.jar, and all looks good to me now. Let's cross fingers for the /releases/staging repository build and for the package build... ;-) my understanding is this is fixed, correct? Yepp, confirmed in Indigo RC4 last week and today in /releases/staging (==RC5). |