Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 348885

Summary: [UI] Removing an element from the model should (eventually) call removeGui on it
Product: [Eclipse Project] Platform Reporter: Eric Moffatt <emoffatt>
Component: UIAssignee: Platform UI Triaged <platform-ui-triaged>
Status: CLOSED WONTFIX QA Contact:
Severity: normal    
Priority: P3 CC: remy.suen
Version: 4.1   
Target Milestone: ---   
Hardware: PC   
OS: Windows XP   
Whiteboard: stalebug

Description Eric Moffatt CLA 2011-06-09 08:59:52 EDT 
Right now we see that we need to use a special pattern of calling 'setToBeRendered(false)' before removing an element from the model. This should be automatic.

Note that transient cases such as moving a part from one stack to another should *not* cause the removeGui to be called so some sort of staged handling will be necessary.

Three approaches come to mind:

1) Use an asynch.

2) Use tags; operations that know they're going to put the element back into the model would tag the element with something like 'NoRemove' before removing it from the model and remove the tag once it's been re-inserted.

3) Explicitly switch all 'move' operations over to using the implicit Move pattern (i.e. just adding it to the new container) and the PRE should be able to detect the difference between a permanent removal and a 'move' op.
Comment 1 Eric Moffatt CLA 2011-09-15 12:52:55 EDT 
M2 is done...
Comment 2 John Arthorne CLA 2012-04-24 11:11:11 EDT 
Please review target milestone and bump to > 4.2 if appropriate.
Comment 3 Eric Moffatt CLA 2013-10-21 10:30:53 EDT 
I'm pretty sure that the CleanupAddon already does this...
Comment 4 Paul Webster CLA 2014-02-03 10:13:24 EST 
Eric to confirm and close.
Comment 5 Eclipse Genie CLA 2020-02-03 13:06:31 EST 
This bug hasn't had any activity in quite some time. Maybe the problem got resolved, was a duplicate of something else, or became less pressing for some reason - or maybe it's still relevant but just hasn't been looked at yet. As such, we're closing this bug.

If you have further information on the current state of the bug, please add it and reopen this bug. The information can be, for example, that the problem still occurs, that you still want the feature, that more information is needed, or that the bug is (for whatever reason) no longer relevant.

--
The automated Eclipse Genie.