Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 348789

Summary:	[editor] many keybindings are running the user agent default handler
Product:	[ECD] Orion	Reporter:	Felipe Heidrich <eclipse.felipe>
Component:	Client	Assignee:	Felipe Heidrich <eclipse.felipe>
Status:	RESOLVED FIXED	QA Contact:
Severity:	normal
Priority:	P3	CC:	Silenio_Quarti, susan
Version:	0.2
Target Milestone:	0.2
Hardware:	PC
OS:	Windows 7
Whiteboard:

Description Felipe Heidrich

2011-06-08 14:26:00 EDT

to mention a few, ctrl+s, ctrl shift k, etc

this is because quite few places (most in editorFeatures.js) are not returning true to indicate that the action should stop the default handler. this bug was brought to surface when  Bug 347875 was fixed.

Comment 1 Felipe Heidrich

2011-06-08 14:27:37 EDT

I'll release the fix soon.

Comment 2 Felipe Heidrich

2011-06-08 14:52:46 EDT

http://git.eclipse.org/c/e4/org.eclipse.orion.client.git/commit/?id=5f7bba4ff23ff70ce06a2af3ddbb1d15a031c770
http://git.eclipse.org/c/e4/org.eclipse.orion.client.git/commit/?id=f90cb18499d632e69d7ba12f00c6c07fb27661fc
fixed


Susan, you probably want to check for more place where the same problem can be happening. Fixing Bug 347875 was maybe a bad idea. But lets try to go forward.

Comment 3 Felipe Heidrich

2011-06-08 15:06:11 EDT

fixed