Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 348715

Summary: Last element of a git commit may be >null
Product: z_Archived Reporter: Alvaro Sanchez-Leon <alvaro.sanchez-leon>
Component: MylynAssignee: Sebastien Dubois <sebastien.dubois>
Status: RESOLVED FIXED QA Contact:
Severity: normal    
Priority: P3 CC: lmcbout
Version: unspecified   
Target Milestone: ---   
Hardware: All   
OS: All   
Whiteboard:

Description Alvaro Sanchez-Leon CLA 2011-06-08 08:19:31 EDT
For some commits the last file context included in a commit may be display as "> null"
to reproduce the problem:

1) Add the following commit to a review
    2011-May-02, 12:24:45 on project org.eclipse.jgit, id: b2b58feba...
2) close and open the review

3) See the last element as ">null" and see in properties, the target file is not populated, the path in the base file is not populated either.
Comment 1 Sebastien Dubois CLA 2011-06-10 15:12:45 EDT
The problem was that we were only checking the name in EditorProxy#findReusableCompareEditor.  We now check if the file revision objects are matching.  This should fix the problem