Bugzilla – Full Text Bug Listing
| Summary: | Setting tooptip to null in tool behavior provider doesn't clear up tooltip if the associated figure has a previous tooltip | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | [Modeling] Graphiti | Reporter: | Shenxue Zhou <shenxue.zhou> | ||||||
| Component: | Core | Assignee: | Project Inbox <graphiti-inbox> | ||||||
| Status: | CLOSED FIXED | QA Contact: | |||||||
| Severity: | major | ||||||||
| Priority: | P3 | CC: | michael.wenz | ||||||
| Version: | 0.8.0 | Flags: | michael.wenz:
juno+
|
||||||
| Target Milestone: | 0.9.0 | ||||||||
| Hardware: | All | ||||||||
| OS: | All | ||||||||
| Whiteboard: | Juno M1 theme_bugs Indigo SR1 | ||||||||
| Attachments: |
|
||||||||
|
Description
Shenxue Zhou
Created attachment 197551 [details]
clear figure's tooltip when the tool behavior provider return null or empty tooltip
Definitely right, but I'm afraid we won't get this into 0.8.0. Today's the last day for changes (only fixing or severe bugs or issue with clearly no side-effects). Although I would tend to see this as in the second category, since you provided a patch for this, it will be IP log relevant and IP log is definitely closed for 0.8.0 Indigo. So I see this as a candidate for Indigo SR1. Thanks for the patch anyway! Michael Understandable. We'll wait for your Indigo SR1 release. Thanks! Shenxue, while having a closer look and trying to reproduce this I tried to come up with an automated test for this. During that I noticed that this should actually work, at least for EMF domain models. The tooltip gets cleared during the diagram editor refresh triggered by DiagramChangeListener, which is registered as a resource set listener. After the domain model change the tooltip (and other relevant stuff) is cleared (see PictogramElementDelegate.indicateNeededUopdates - Line 922) and afterwards automatically asked for again (where you applied the fix). No I wonder if this is a gap in non-EMF domain model handling on our side or maybe a notifictaion gap in your tool. What happens in your tool on domain model changes? Do they somehow trigger a diagram editor refresh? Michael I had another look into this and found that my test case only works because it uses a simple and straightforward case: the ECore test tool has no ghost shapes and/or different selection shapes. As soon as I try this with the tutorial (by setting an empty name for an EClass it is possible to set no tooltip) it does not work any more: after cleaning the tooltip it won't vanish from the UI. It showed that the cleaning of the tooltip in the case of a different selection shape than the tooltip shape does not work correctly. I assume that you have a similar scenario. I have changed the retrieval and setting process for the tooltips so that works reliably now. My change is checked-in to head. Could you please test the change in your scenario before I downport it to Indigo SR1? Michael Created attachment 198836 [details]
Patch containing the change checked-in to head
Attached is the change I did to head for downporting to Indigo SR1. You may also use this for testing the change.
Michael
(In reply to comment #6) > Created attachment 198836 [details] > Patch containing the change checked-in to head > > Attached is the change I did to head for downporting to Indigo SR1. You may > also use this for testing the change. > > Michael I'd love to test this bug fix. But where could I get a hold of the ZIP file? Thanks! Shenxue, you can test this either using our head/dev build (see our download page for the ZIP location) or by applying the attached patch if you have the Graphiti sources synced locally. Michael (In reply to comment #8) > Shenxue, > > you can test this either using our head/dev build (see our download page for > the ZIP location) or by applying the attached patch if you have the Graphiti > sources synced locally. > > Michael I tested the fix by syncing Graphiti plugins to the latest. It worked great. Thanks! When will be the next milestone build available? Currently we are using org.eclipse.graphiti.site_0.8.0.201106071252.zip. Thanks for testing! I have downported and checked-in the bugfix to our 0.8.x branch. It will be part of Indigo SR1. Michael (In reply to comment #9) Shenxue, our next milestone builds are still way ahead: for the Indigo-based release 0.8.x it will be SR1 RC1, for our head version it will be Juno M1 (both on August 19). I would suggest that we provide an integration build for you to use. Just let me know if you would prefer to get the 0.8- (Indigo-) based or the head version (targeting Juno) build or both? Michael > When will be the next milestone build available? Currently we are using > org.eclipse.graphiti.site_0.8.0.201106071252.zip. (In reply to comment #11) > (In reply to comment #9) > Shenxue, > our next milestone builds are still way ahead: for the Indigo-based release > 0.8.x it will be SR1 RC1, for our head version it will be Juno M1 (both on > August 19). > > I would suggest that we provide an integration build for you to use. Just let > me know if you would prefer to get the 0.8- (Indigo-) based or the head version > (targeting Juno) build or both? > > Michael > Could you provide an integration build based on 0.8.x for us? I think that's enough for us now. Thanks, Shenxue (In reply to comment #12) I have done an integration build for Graphiti 0.8 (version for Indigo SR1) and made the results available at the following locations: - Update site: http://download.eclipse.org/graphiti/updates/integration/0.8.x - ZIP: http://download.eclipse.org/graphiti/archives/integration/0.8.x/org.eclipse.graphiti.site_0.8.0.201107141140.zip Let me know in case of any issues, Michael > (In reply to comment #11) > > (In reply to comment #9) > > Shenxue, > > our next milestone builds are still way ahead: for the Indigo-based release > > 0.8.x it will be SR1 RC1, for our head version it will be Juno M1 (both on > > August 19). > > > > I would suggest that we provide an integration build for you to use. Just let > > me know if you would prefer to get the 0.8- (Indigo-) based or the head version > > (targeting Juno) build or both? > > > > Michael > > > Could you provide an integration build based on 0.8.x for us? I think that's > enough for us now. Thanks, > Shenxue Bookkeeping: Set target release Part of Graphiti 0.9.0 (Eclipse Juno) |