Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 348637

Summary:	Direct-editing box for connection text decorator has size issues
Product:	[Modeling] Graphiti	Reporter:	Shenxue Zhou <shenxue.zhou>
Component:	Core	Assignee:	Project Inbox <graphiti-inbox>
Status:	CLOSED FIXED	QA Contact:
Severity:	enhancement
Priority:	P3	CC:	matthias.gorning, michael.wenz
Version:	0.8.0	Flags:	matthias.gorning: indigo+ michael.wenz: juno+
Target Milestone:	0.8.0
Hardware:	All
OS:	All
Whiteboard:	Indigo SR1 theme_bugs Juno M1

Description Shenxue Zhou

2011-06-07 15:50:54 EDT

For text added as a connection decorator, when invoking direct-editing on it, I noticed the following issues:

1. When the text decorator has focus, a resizable handle appears around the text. However, if you try to resize it, it won't resize.

2. The cell editor used for direct editing seems to have fixed size. Calling gaService.setLocationAndSize() on the text doesn't have any effect on the cell editor size. This behaves differently from the cell editor used by node. 

3. While editing the text on the connection, the cell editor won't adjust its size accordingly. But it re-adjusts the size after direct editing is finished.

Comment 1 Matthias Gorning

2011-06-10 05:00:27 EDT

Currently everything works as designed from my point of view.

But you are right. We can do some improvements. Please, can you describe the expected behaviour for all of your issues?

We will treat them as enhancement requests.

Comment 2 Shenxue Zhou

2011-06-13 12:38:09 EDT

(In reply to comment #1)
> Currently everything works as designed from my point of view.
> 
> But you are right. We can do some improvements. Please, can you describe the
> expected behaviour for all of your issues?
> 
> We will treat them as enhancement requests.

Let me try:

1. If the connection label (added as connection decorator) isn't resizable, then the resize handle should not appear when the connection label is selected.

2. When the connection label is in "direct-edit" mode, the positioning of the highlight obscures the text at the left. 

3. The direct editing box of the connection label is not consistent with the direct editing box of a node. With a node, I can specify the width and height of the text label and when the text is in direct editing mode, the cell editor uses that width and height. But for connection label, setting the label width and height has no effect on the cell editor size. For small labels, with the issue described in 2, it's very hard to see the text.

Comment 3 Matthias Gorning

2011-06-15 10:02:59 EDT

1. 

It's fixed for Indigo SR1

2. and 3. 

Please override the method 

public boolean stretchFieldToFitText()

in your direct editing feature which is responsible for your label decorator.

Comment 4 Matthias Gorning

2011-06-15 10:04:02 EDT

See last comment.

Comment 5 Michael Wenz

2011-07-14 08:14:02 EDT

Marked as part of Juno

Comment 6 Michael Wenz

2012-06-28 10:36:29 EDT

Part of Graphiti 0.9.0 (Eclipse Juno)