Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 348584

Summary:	API tools install execution environment link not working in 4.1
Product:	[Eclipse Project] e4	Reporter:	dkniphu
Component:	UI	Assignee:	Project Inbox <e4.ui-inbox>
Status:	CLOSED DUPLICATE	QA Contact:
Severity:	minor
Priority:	P3	CC:	bokowski, curtis.windatt.public, daniel_megert, emoffatt, Michael_Rennie, prakash, pwebster, remy.suen
Version:	1.0
Target Milestone:	---
Hardware:	PC
OS:	Windows XP
Whiteboard:

Description dkniphu

2011-06-07 10:54:22 EDT

Build Identifier: I20110524-1000

In the preferences window under Plug-in Development -> API Errors/Warnings.
Under API Use tab there is a link "install them now" that is supposed to open the install software screen. It currently does nothing. The install software screen can still be accessed by the help menu.

(If the link is greyed out, change the "ignore" option to the top right to warning or error.)

Reproducible: Always

Steps to Reproduce:
1. Go to the preferences window (Window -> Preferences).
2. Plug-in Development -> API Errors/Warnings. Select the API Use tab.
3. Make sure the options on the right are all warning or error.
4. Click on "install them now".

Comment 1 dkniphu

2011-06-07 11:14:51 EDT

Following the same instructions in the corresponding 3.7 build, the link works correctly.

Comment 2 Boris Bokowski

2011-06-07 11:31:27 EDT

This is most likely a problem in 4.1, not PDE.

Comment 3 Curtis Windatt

2011-06-07 11:37:04 EDT

(In reply to comment #2)
> This is most likely a problem in 4.1, not PDE.

This is working fine in 3.7 builds, moving to Platform UI for comment.

Comment 4 Remy Suen

2011-06-07 11:58:37 EDT

Looks like PDE is executing the command directly instead of using the IHandlerService.

Thread [main] (Suspended (breakpoint at line 1803 in Workbench$MakeHandlersGo))	
	Workbench$MakeHandlersGo.execute(ExecutionEvent) line: 1803	
	Command.executeWithChecks(ExecutionEvent) line: 476	
	ApiErrorsWarningsConfigurationBlock$4.widgetSelected(SelectionEvent)

Comment 5 Curtis Windatt

2011-06-07 12:55:01 EDT

(In reply to comment #4)
> Looks like PDE is executing the command directly instead of using the
> IHandlerService.
> 
> Thread [main] (Suspended (breakpoint at line 1803 in Workbench$MakeHandlersGo)) 
>     Workbench$MakeHandlersGo.execute(ExecutionEvent) line: 1803    
>     Command.executeWithChecks(ExecutionEvent) line: 476    
>     ApiErrorsWarningsConfigurationBlock$4.widgetSelected(SelectionEvent)

Sounds like something we should change.

Comment 6 Dani Megert

2011-06-07 13:03:40 EDT

(In reply to comment #5)
> (In reply to comment #4)
> > Looks like PDE is executing the command directly instead of using the
> > IHandlerService.
> > 
> > Thread [main] (Suspended (breakpoint at line 1803 in Workbench$MakeHandlersGo)) 
> >     Workbench$MakeHandlersGo.execute(ExecutionEvent) line: 1803    
> >     Command.executeWithChecks(ExecutionEvent) line: 476    
> >     ApiErrorsWarningsConfigurationBlock$4.widgetSelected(SelectionEvent)
> 
> Sounds like something we should change.

We could but on the other hand this is what one does if one wants to invoke the current handler for the command at hand. And its official API which I think is also (indirectly) used by ContributedAction.

Comment 7 Prakash Rangaraj

2011-06-08 05:49:11 EDT

(In reply to comment #6)
> (In reply to comment #5)
> > (In reply to comment #4)
> > > Looks like PDE is executing the command directly instead of using the
> > > IHandlerService.
> > > 
> > > Thread [main] (Suspended (breakpoint at line 1803 in Workbench$MakeHandlersGo)) 
> > >     Workbench$MakeHandlersGo.execute(ExecutionEvent) line: 1803    
> > >     Command.executeWithChecks(ExecutionEvent) line: 476    
> > >     ApiErrorsWarningsConfigurationBlock$4.widgetSelected(SelectionEvent)
> > 
> > Sounds like something we should change.
> 
> We could but on the other hand this is what one does if one wants to invoke the
> current handler for the command at hand. And its official API which I think is
> also (indirectly) used by ContributedAction.


   Bug# 348692 raised to handle ContributedAction. Moving this to bug PDE.

Comment 8 Dani Megert

2011-06-08 05:52:19 EDT

(In reply to comment #7)
> (In reply to comment #6)
> > (In reply to comment #5)
> > > (In reply to comment #4)
> > > > Looks like PDE is executing the command directly instead of using the
> > > > IHandlerService.
> > > > 
> > > > Thread [main] (Suspended (breakpoint at line 1803 in Workbench$MakeHandlersGo)) 
> > > >     Workbench$MakeHandlersGo.execute(ExecutionEvent) line: 1803    
> > > >     Command.executeWithChecks(ExecutionEvent) line: 476    
> > > >     ApiErrorsWarningsConfigurationBlock$4.widgetSelected(SelectionEvent)
> > > 
> > > Sounds like something we should change.
> > 
> > We could but on the other hand this is what one does if one wants to invoke the
> > current handler for the command at hand. And its official API which I think is
> > also (indirectly) used by ContributedAction.
> 
> 
>    Bug# 348692 raised to handle ContributedAction. Moving this to bug PDE.

This is not a PDE bug. The API which is used should work and there might be other clients relying on that. This should be fixed in the compatibility layer.

Comment 9 Paul Webster

2011-06-08 07:06:36 EDT

(In reply to comment #8)

> > 
> >    Bug# 348692 raised to handle ContributedAction. Moving this to bug PDE.
> 
> This is not a PDE bug. The API which is used should work and there might be
> other clients relying on that. This should be fixed in the compatibility layer.

It's API in the way Actions are API ... it's not recommended, but it is sometimes necessary in 3.x.  ContributedAction was written that way because it was necessary.  IHandlerService won't do the correct thing.    I agree with Dani that it must be fixed, see bug 328971

I would still recommend PDE use IHandlerService to execute their command, unless they have a need similar to ContributedAction.

PW

Comment 10 Dani Megert

2011-06-08 08:05:18 EDT

> I would still recommend PDE use IHandlerService to execute their command,
> unless they have a need similar to ContributedAction.
> 
> PW

Sounds fair. Filed bug 348711 to track that.

Comment 11 Paul Webster

2011-06-10 08:18:27 EDT

This now works in 4.1 I20110609-2200

PW

*** This bug has been marked as a duplicate of bug 328971 ***

Comment 12 Remy Suen

2011-06-10 10:34:04 EDT

Thank you for the bug report, David.