Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 348551

Summary:

[server][git] Branch.CommitLocation and Remote.CommitLocation should accept the parameter pageSize.

Product:

[ECD] Orion

Reporter:

Malgorzata Janczarska <malgorzata.tomczyk>

Component:

Client

Assignee:

Malgorzata Janczarska <malgorzata.tomczyk>

Status:

RESOLVED FIXED

QA Contact:

Severity:

normal

Priority:

CC:

libingw, Szymon.Brandys, tomasz.zarna

Version:

0.2

Flags:

tomasz.zarna: review+

Target Milestone:

0.2

Hardware:

OS:

Windows XP

Whiteboard:

Bug Depends on:

Bug Blocks:

345978, 345980, 345981

Attachments:

Description	Flags
Change for review	none

Description Malgorzata Janczarska

2011-06-07 08:53:59 EDT

Page size for commit list obtained by Branch.CommitLocation and Remote.CommitLocation should allow to change pageSize.

Comment 1 Malgorzata Janczarska

2011-06-07 13:02:32 EDT

Created attachment 197522 [details]
Change for review

I'm attaching a small change that uses pageSize when provided. Otherwise it uses the default size witch is currently 50.

Comment 2 Tomasz Zarna

2011-06-08 05:32:12 EDT

Looks good, a test case double checking if the new param works would be great though.

Comment 3 Malgorzata Janczarska

2011-06-08 06:36:20 EDT

I added test case and pushed changes.

Libing, you can try now "?page=1&pageSize=5" instead of "?page=1".