Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 348458

Summary:	[releng] Stuck process from build tests
Product:	[ECD] Orion	Reporter:	John Arthorne <john.arthorne>
Component:	Client	Assignee:	Project Inbox <e4.orion-inbox>
Status:	RESOLVED FIXED	QA Contact:
Severity:	normal
Priority:	P3	CC:	aniefer
Version:	0.2
Target Milestone:	0.2
Hardware:	PC
OS:	Windows 7
Whiteboard:

Description John Arthorne

2011-06-06 14:57:36 EDT

Each build is leaving behind a test process that never dies. This process is preventing build directories from being deleted by subsequent builds. I have to manually kill this process before each build to ensure the next one will run cleanly.

e4Build  12217  0.0  0.4 770700 108972 ?       Sl   11:38   0:10 /shared/eclipse/e4/orion/I201106061111/test/eclipse/orion -vm /shared/common/sun-jdk1.6.0_21_x64/jre/lib/amd64/server/libjvm.so

Comment 1 Andrew Niefer

2011-06-20 17:41:57 EDT

The runTests.xml script is supposed to get the server's process id ("serverPID") as the output of the runTests.sh shell script.  Later it is then supposed to kill the server using kill.

We should check that we are getting the correct process id here, we can add some echo statements to verify.  If this is correct, we could consider changing the kill to "kill -9" to be more forcefull.

Comment 2 John Arthorne

2011-06-23 14:47:25 EDT

Andrew fixed this. All hail the build king.

Comment 3 Andrew Niefer

2011-06-23 14:52:53 EDT

This is the relevant commit:
http://git.eclipse.org/c/e4/org.eclipse.orion.server.git/commit/?id=73a3dafa3eb9a7afa6f5ea95137bd737dca4fc47

I'm not completely clear on why the process was hanging around.  This change is regarding removing the "-console" from the eclipse.ini, this started failing when the launcher was renamed to orion (orion.ini).

This line of the shell script was failing, which may have interfered with returning the process id, or the console could have somehow blocked the process from exiting or otherwise interfered since the server would have been running in the background.